Re: [Intel-gfx] [PATCH] drm/i915: Only close vma we open

2020-04-24 Thread Andi Shyti
On Fri, Apr 24, 2020 at 11:22:13AM +0100, Chris Wilson wrote: > Quoting Andi Shyti (2020-04-24 11:16:17) > > Hi Chris, > > > > On Wed, Apr 22, 2020 at 08:05:58PM +0100, Chris Wilson wrote: > > > The history of i915_vma_close() is confusing, as is its use. As the > > > lifetime of the i915_vma is c

Re: [Intel-gfx] [PATCH] drm/i915: Only close vma we open

2020-04-24 Thread Andi Shyti
Hi Chris, On Wed, Apr 22, 2020 at 08:05:58PM +0100, Chris Wilson wrote: > The history of i915_vma_close() is confusing, as is its use. As the > lifetime of the i915_vma is currently bounded by the object it is > attached to, we needed a means of identify when a vma was no longer in > use by usersp

Re: [Intel-gfx] [PATCH] drm/i915: Only close vma we open

2020-04-24 Thread Chris Wilson
Quoting Andi Shyti (2020-04-24 11:16:17) > Hi Chris, > > On Wed, Apr 22, 2020 at 08:05:58PM +0100, Chris Wilson wrote: > > The history of i915_vma_close() is confusing, as is its use. As the > > lifetime of the i915_vma is currently bounded by the object it is > > attached to, we needed a means of

[Intel-gfx] [PATCH] drm/i915: Only close vma we open

2020-04-22 Thread Chris Wilson
The history of i915_vma_close() is confusing, as is its use. As the lifetime of the i915_vma is currently bounded by the object it is attached to, we needed a means of identify when a vma was no longer in use by userspace (via the user's fd). This is further complicated by that only ppgtt vma shoul