Re: [Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

2013-10-22 Thread Daniel Vetter
On Tue, Oct 22, 2013 at 10:15 AM, Ville Syrjälä wrote: > FLIP_DONE etc. interrupts already depend on the crtc being there. Not > sure why this is different. I'd say we've simply lucked out thus far. E.g. on vlv the init_clock_gating flushes the primary plane and so casues a flip done interrupt. B

Re: [Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

2013-10-22 Thread Ville Syrjälä
On Mon, Oct 21, 2013 at 10:54:16PM +0200, Daniel Vetter wrote: > On Mon, Oct 21, 2013 at 10:47 PM, Damien Lespiau > wrote: > > On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote: > >> Adding stuff to the bottom of struct drm_i915_driver_private is > >> nowadays considered uncool. > >> >

Re: [Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

2013-10-21 Thread Daniel Vetter
On Mon, Oct 21, 2013 at 10:47 PM, Damien Lespiau wrote: > On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote: >> Adding stuff to the bottom of struct drm_i915_driver_private is >> nowadays considered uncool. >> >> Cc: Damien Lespiau >> Signed-off-by: Daniel Vetter > > Ville was sugges

Re: [Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

2013-10-21 Thread Damien Lespiau
On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote: > Adding stuff to the bottom of struct drm_i915_driver_private is > nowadays considered uncool. > > Cc: Damien Lespiau > Signed-off-by: Daniel Vetter Ville was suggesting moving the pipe_crc struct into intel_crtc. Might be even bet

[Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

2013-10-21 Thread Daniel Vetter
Adding stuff to the bottom of struct drm_i915_driver_private is nowadays considered uncool. Cc: Damien Lespiau Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_drv.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/g