Re: [Intel-gfx] [PATCH] drm/i915: Move hsw GT w/a to engine initialisation

2017-11-06 Thread Chris Wilson
Quoting Chris Wilson (2017-11-03 10:38:38) > Quoting Ville Syrjälä (2017-11-03 10:25:17) > > This problem doesn't seem like it should be specific to HSW. So I wonder > > if we should start by just reverting that offending patch and move just > > the watermark thing out to some earlier position in t

Re: [Intel-gfx] [PATCH] drm/i915: Move hsw GT w/a to engine initialisation

2017-11-03 Thread Chris Wilson
Quoting Ville Syrjälä (2017-11-03 10:25:17) > On Fri, Nov 03, 2017 at 02:56:28AM +, Chris Wilson wrote: > > In commit b7048ea12fbb ("drm/i915: Do .init_clock_gating() earlier to > > avoid it clobbering watermarks") init_clock_gating was called earlier in > > the module load sequence, moving it

Re: [Intel-gfx] [PATCH] drm/i915: Move hsw GT w/a to engine initialisation

2017-11-03 Thread Ville Syrjälä
On Fri, Nov 03, 2017 at 02:56:28AM +, Chris Wilson wrote: > In commit b7048ea12fbb ("drm/i915: Do .init_clock_gating() earlier to > avoid it clobbering watermarks") init_clock_gating was called earlier in > the module load sequence, moving it before we acquired the forcewake > used to initialis

[Intel-gfx] [PATCH] drm/i915: Move hsw GT w/a to engine initialisation

2017-11-02 Thread Chris Wilson
In commit b7048ea12fbb ("drm/i915: Do .init_clock_gating() earlier to avoid it clobbering watermarks") init_clock_gating was called earlier in the module load sequence, moving it before we acquired the forcewake used to initialise the engines. This revealed that on Haswell, at least, some of those