Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-06 Thread Daniel Vetter
On Tue, Jan 06, 2015 at 03:15:39PM +0800, Xiang, Haihao wrote: > On Mon, 2015-01-05 at 23:03 -0800, Kenneth Graunke wrote: > > On Tuesday, January 06, 2015 02:39:36 PM Xiang, Haihao wrote: > > > On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > > > > On Tuesday, January 06, 2015 01:11:53

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Xiang, Haihao
On Mon, 2015-01-05 at 23:03 -0800, Kenneth Graunke wrote: > On Tuesday, January 06, 2015 02:39:36 PM Xiang, Haihao wrote: > > On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > > > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > > > > > > > Hi Kenneth, > > > > > > > > H

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Kenneth Graunke
On Tuesday, January 06, 2015 02:39:36 PM Xiang, Haihao wrote: > On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > > > > > Hi Kenneth, > > > > > > How did you test OSD ? I can't reproduce the issue you mentioned, OSD > >

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Xiang, Haihao
On Tue, 2015-01-06 at 14:39 +0800, Xiang, Haihao wrote: > On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > > > > > Hi Kenneth, > > > > > > How did you test OSD ? I can't reproduce the issue you mentioned, OSD > > > wor

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Xiang, Haihao
On Mon, 2015-01-05 at 21:54 -0800, Kenneth Graunke wrote: > On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > > > Hi Kenneth, > > > > How did you test OSD ? I can't reproduce the issue you mentioned, OSD > > works well for me when using mplayer-vaapi with the latest > > libva/libv

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Kenneth Graunke
On Tuesday, January 06, 2015 01:11:53 PM Xiang, Haihao wrote: > > Hi Kenneth, > > How did you test OSD ? I can't reproduce the issue you mentioned, OSD > works well for me when using mplayer-vaapi with the latest > libva/libva-intel-driver master branch. > > I tried your patch, what surprised me

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Xiang, Haihao
Hi Kenneth, How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch. I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Kenneth Graunke
On Monday, January 05, 2015 02:19:15 PM Daniel Vetter wrote: > On Wed, Dec 31, 2014 at 04:23:00PM -0800, Kenneth Graunke wrote: > > Haswell significantly improved the performance of sampler_c messages, > > but the optimization appears to be off by default. Later platforms > > remove this bit, and

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-05 Thread Daniel Vetter
On Wed, Dec 31, 2014 at 04:23:00PM -0800, Kenneth Graunke wrote: > Haswell significantly improved the performance of sampler_c messages, > but the optimization appears to be off by default. Later platforms > remove this bit, and apparently always enable the optimization. > > Improves performance

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2015-01-04 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) -Summary- Platform Delta drm-intel-nightly Series Applied PNV 363/364

[Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-12-31 Thread Kenneth Graunke
Haswell significantly improved the performance of sampler_c messages, but the optimization appears to be off by default. Later platforms remove this bit, and apparently always enable the optimization. Improves performance in "Counter Strike: Global Offensive" by 18% at default settings on Iris Pr

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-11 Thread Daniel Vetter
On Fri, Nov 07, 2014 at 10:46:31AM -0800, Matt Turner wrote: > On Wed, Oct 29, 2014 at 2:12 PM, Kenneth Graunke > wrote: > > Haswell significantly improved the performance of sampler_c messages, > > but the optimization appears to be off by default. Later platforms > > remove this bit, and appar

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-07 Thread Matt Turner
On Wed, Oct 29, 2014 at 2:12 PM, Kenneth Graunke wrote: > Haswell significantly improved the performance of sampler_c messages, > but the optimization appears to be off by default. Later platforms > remove this bit, and apparently always enable the optimization. > > Improves performance in "Count

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-04 Thread Xiang, Haihao
On Mon, 2014-11-03 at 13:48 +0100, Daniel Vetter wrote: > On Fri, Oct 31, 2014 at 11:27:33AM +0200, Ville Syrjälä wrote: > > On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: > > > Before we get too much further...we should check if libva is actually > > > broken. > > > I don't know

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-03 Thread Dave Gordon
On 30/10/14 19:26, Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: >> On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: >>> On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: On Thursday, October 30, 2014 11:00:51 AM Ville Syrj

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-11-03 Thread Daniel Vetter
On Fri, Oct 31, 2014 at 11:27:33AM +0200, Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: > > Before we get too much further...we should check if libva is actually > > broken. > > I don't know if this means the sampler palette completely doesn't work, or >

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-31 Thread Jani Nikula
[off-topic] On Fri, 31 Oct 2014, Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: >> I don't think HALF_SLICE_CHICKEN3 is part of the logical context, FWIW. > > Oh but it is. Lots of chickens like to nest in the context. In the context of lunch, HALF_SLICE

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-31 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 12:57:04PM -0700, Kenneth Graunke wrote: > On Thursday, October 30, 2014 09:26:01 PM Ville Syrjälä wrote: > > On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: > > > On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > > > > On Thu, Oct 30, 2014 at

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Kenneth Graunke
On Thursday, October 30, 2014 09:26:01 PM Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: > > On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > > > On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: > > > > On Thursday, October 30

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 10:32:38AM -0700, Kenneth Graunke wrote: > On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > > On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: > > > On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä wrote: > > > > On Thu, Oct 30, 2014 at

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Kenneth Graunke
On Thursday, October 30, 2014 01:01:30 PM Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: > > On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä wrote: > > > On Thu, Oct 30, 2014 at 10:50:03AM +0200, Ville Syrjälä wrote: > > > > On Wed, Oct 29, 2014 at 0

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 02:32:40AM -0700, Kenneth Graunke wrote: > On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä wrote: > > On Thu, Oct 30, 2014 at 10:50:03AM +0200, Ville Syrjälä wrote: > > > On Wed, Oct 29, 2014 at 03:12:43PM -0700, Kenneth Graunke wrote: > > > > Haswell significantly i

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Kenneth Graunke
On Thursday, October 30, 2014 11:00:51 AM Ville Syrjälä wrote: > On Thu, Oct 30, 2014 at 10:50:03AM +0200, Ville Syrjälä wrote: > > On Wed, Oct 29, 2014 at 03:12:43PM -0700, Kenneth Graunke wrote: > > > Haswell significantly improved the performance of sampler_c messages, > > > but the optimization

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Ville Syrjälä
On Thu, Oct 30, 2014 at 10:50:03AM +0200, Ville Syrjälä wrote: > On Wed, Oct 29, 2014 at 03:12:43PM -0700, Kenneth Graunke wrote: > > Haswell significantly improved the performance of sampler_c messages, > > but the optimization appears to be off by default. Later platforms > > remove this bit, an

Re: [Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-30 Thread Ville Syrjälä
On Wed, Oct 29, 2014 at 03:12:43PM -0700, Kenneth Graunke wrote: > Haswell significantly improved the performance of sampler_c messages, > but the optimization appears to be off by default. Later platforms > remove this bit, and apparently always enable the optimization. > > Improves performance

[Intel-gfx] [PATCH] drm/i915: Make sample_c messages go faster on Haswell.

2014-10-29 Thread Kenneth Graunke
Haswell significantly improved the performance of sampler_c messages, but the optimization appears to be off by default. Later platforms remove this bit, and apparently always enable the optimization. Improves performance in "Counter Strike: Global Offensive" by 18% at default settings on Iris Pr