Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 02:53:09PM +0100, Daniel Vetter wrote: > On Thu, Nov 06, 2014 at 09:25:22AM +, Chris Wilson wrote: > > On Thu, Nov 06, 2014 at 11:03:40AM +0200, Ander Conselvan de Oliveira wrote: > > > This simplifies the code quite a bit compared to iterating over all > > > rings durin

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Daniel Vetter
On Thu, Nov 06, 2014 at 09:25:22AM +, Chris Wilson wrote: > On Thu, Nov 06, 2014 at 11:03:40AM +0200, Ander Conselvan de Oliveira wrote: > > This simplifies the code quite a bit compared to iterating over all > > rings during the ring interrupt. > > > > Also, it allows us to drop the mmio_flip

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Chris Wilson
On Thu, Nov 06, 2014 at 11:03:40AM +0200, Ander Conselvan de Oliveira wrote: > This simplifies the code quite a bit compared to iterating over all > rings during the ring interrupt. > > Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip > struct is only accessed in two places.

[Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-06 Thread Ander Conselvan de Oliveira
This simplifies the code quite a bit compared to iterating over all rings during the ring interrupt. Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip struct is only accessed in two places. The first is when the flip is queued and the other when the mmio writes are done. Since

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-05 Thread Chris Wilson
On Wed, Nov 05, 2014 at 02:23:07PM +0200, Ander Conselvan de Oliveira wrote: > On 11/05/2014 01:23 PM, Chris Wilson wrote: > >On Wed, Nov 05, 2014 at 01:03:00PM +0200, Ander Conselvan de Oliveira wrote: > >>This simplifies the code quite a bit compared to iterating over all > >>rings during the rin

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-05 Thread Ander Conselvan de Oliveira
On 11/05/2014 01:23 PM, Chris Wilson wrote: On Wed, Nov 05, 2014 at 01:03:00PM +0200, Ander Conselvan de Oliveira wrote: This simplifies the code quite a bit compared to iterating over all rings during the ring interrupt. Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip st

Re: [Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-05 Thread Chris Wilson
On Wed, Nov 05, 2014 at 01:03:00PM +0200, Ander Conselvan de Oliveira wrote: > This simplifies the code quite a bit compared to iterating over all > rings during the ring interrupt. > > Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip > struct is only accessed in two places.

[Intel-gfx] [PATCH] drm/i915: Make mmio flip wait for seqno in the work function

2014-11-05 Thread Ander Conselvan de Oliveira
This simplifies the code quite a bit compared to iterating over all rings during the ring interrupt. Also, it allows us to drop the mmio_flip spinlock, since the mmio_flip struct is only accessed in two places. The first is when the flip is queued and the other when the mmio writes are done. Since