Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-28 Thread Joonas Lahtinen
On ke, 2016-01-27 at 17:32 +, Dave Gordon wrote: > On 26/01/16 09:44, Joonas Lahtinen wrote: > > On ma, 2016-01-25 at 18:57 +, Dave Gordon wrote: > > > On 25/01/16 18:17, Daniel Vetter wrote: > > > > > > > > > I915_DBG(...) ? > > > > > > It's conventional that macros should be UPPERCA

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-27 Thread Daniel Vetter
On Wed, Jan 27, 2016 at 05:32:55PM +, Dave Gordon wrote: > On 26/01/16 09:44, Joonas Lahtinen wrote: > >On ma, 2016-01-25 at 18:57 +, Dave Gordon wrote: > >>On 25/01/16 18:17, Daniel Vetter wrote: > >>>On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com > >>>wrote: > From: Ak

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-27 Thread Dave Gordon
On 26/01/16 09:44, Joonas Lahtinen wrote: On ma, 2016-01-25 at 18:57 +, Dave Gordon wrote: On 25/01/16 18:17, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com wrote: From: Akash Goel Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. dev

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-26 Thread Joonas Lahtinen
On ma, 2016-01-25 at 18:57 +, Dave Gordon wrote: > On 25/01/16 18:17, Daniel Vetter wrote: > > On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com > > wrote: > > > From: Akash Goel > > > > > > Added a new macro i915_dbg, which is a wrapper over dev_dbg > > > macro. > > > dev_dbg al

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-25 Thread Dave Gordon
On 25/01/16 18:17, Daniel Vetter wrote: On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com wrote: From: Akash Goel Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. dev_dbg allows use of dynamic debug framework, so offers a number of advantages over DRM_DEBUG to de

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-25 Thread Daniel Vetter
On Fri, Jan 22, 2016 at 05:54:15PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. > dev_dbg allows use of dynamic debug framework, so offers a number > of advantages over DRM_DEBUG to debug user space startup issues. >

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-22 Thread Chris Wilson
On Fri, Jan 22, 2016 at 12:49:01PM +, Arun Siluvery wrote: > On 22/01/2016 12:24, akash.g...@intel.com wrote: > >From: Akash Goel > > > >Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. > >dev_dbg allows use of dynamic debug framework, so offers a number > >of advantages over

Re: [Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-22 Thread Arun Siluvery
On 22/01/2016 12:24, akash.g...@intel.com wrote: From: Akash Goel Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. dev_dbg allows use of dynamic debug framework, so offers a number of advantages over DRM_DEBUG to debug user space startup issues. Like provides more fine grain c

[Intel-gfx] [PATCH] drm/i915: Introduce i915_dbg macro

2016-01-22 Thread akash . goel
From: Akash Goel Added a new macro i915_dbg, which is a wrapper over dev_dbg macro. dev_dbg allows use of dynamic debug framework, so offers a number of advantages over DRM_DEBUG to debug user space startup issues. Like provides more fine grain control by allowing to enable/disable certain debug