Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Michel Thierry
On 2/24/2017 9:15 AM, Chris Wilson wrote: On Fri, Feb 24, 2017 at 08:30:43AM -0800, Michel Thierry wrote: On 2/24/2017 2:49 AM, Chris Wilson wrote: On Fri, Feb 24, 2017 at 11:43:32AM +0100, Michal Wajdeczko wrote: On Fri, Feb 24, 2017 at 09:13:29AM +, Chris Wilson wrote: On Fri, Feb 24,

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Chris Wilson
On Fri, Feb 24, 2017 at 08:30:43AM -0800, Michel Thierry wrote: > On 2/24/2017 2:49 AM, Chris Wilson wrote: > >On Fri, Feb 24, 2017 at 11:43:32AM +0100, Michal Wajdeczko wrote: > >>On Fri, Feb 24, 2017 at 09:13:29AM +, Chris Wilson wrote: > >>>On Fri, Feb 24, 2017 at 09:13:05AM +0530, Kamble, S

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Michel Thierry
On 2/24/2017 2:49 AM, Chris Wilson wrote: On Fri, Feb 24, 2017 at 11:43:32AM +0100, Michal Wajdeczko wrote: On Fri, Feb 24, 2017 at 09:13:29AM +, Chris Wilson wrote: On Fri, Feb 24, 2017 at 09:13:05AM +0530, Kamble, Sagar A wrote: Reviewed-by: Sagar Arun Kamble [1] On 2/24/2017 4:41

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Michel Thierry
On 2/24/2017 8:15 AM, Michel Thierry wrote: On 2/24/2017 2:40 AM, Michal Wajdeczko wrote: On Thu, Feb 23, 2017 at 03:11:37PM -0800, Michel Thierry wrote: There was no way to check if the platform is running the latest firmware. Can we also add similar patch for the HuC ? Please don't tel

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Michel Thierry
On 2/24/2017 2:40 AM, Michal Wajdeczko wrote: On Thu, Feb 23, 2017 at 03:11:37PM -0800, Michel Thierry wrote: There was no way to check if the platform is running the latest firmware. Can we also add similar patch for the HuC ? Please don't tell me the HuC can hang the gpu too. Cc: Tvr

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Kamble, Sagar A
On 2/24/2017 4:19 PM, Chris Wilson wrote: On Fri, Feb 24, 2017 at 11:43:32AM +0100, Michal Wajdeczko wrote: On Fri, Feb 24, 2017 at 09:13:29AM +, Chris Wilson wrote: On Fri, Feb 24, 2017 at 09:13:05AM +0530, Kamble, Sagar A wrote: Reviewed-by: Sagar Arun Kamble [1] On 2/24/2017

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Chris Wilson
On Fri, Feb 24, 2017 at 11:43:32AM +0100, Michal Wajdeczko wrote: > On Fri, Feb 24, 2017 at 09:13:29AM +, Chris Wilson wrote: > > On Fri, Feb 24, 2017 at 09:13:05AM +0530, Kamble, Sagar A wrote: > > >Reviewed-by: Sagar Arun Kamble [1] > > > > > >On 2/24/2017 4:41 AM, Michel Thierry wro

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Michal Wajdeczko
On Fri, Feb 24, 2017 at 09:13:29AM +, Chris Wilson wrote: > On Fri, Feb 24, 2017 at 09:13:05AM +0530, Kamble, Sagar A wrote: > >Reviewed-by: Sagar Arun Kamble [1] > > > >On 2/24/2017 4:41 AM, Michel Thierry wrote: > > > > There was no way to check if the platform is running the lates

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Michal Wajdeczko
On Thu, Feb 23, 2017 at 03:11:37PM -0800, Michel Thierry wrote: > There was no way to check if the platform is running the latest firmware. Can we also add similar patch for the HuC ? > > Cc: Tvrtko Ursulin > Cc: Arkadiusz Hiler > Signed-off-by: Michel Thierry > --- > drivers/gpu/drm/i915/i9

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-24 Thread Chris Wilson
On Fri, Feb 24, 2017 at 09:13:05AM +0530, Kamble, Sagar A wrote: >Reviewed-by: Sagar Arun Kamble [1] > >On 2/24/2017 4:41 AM, Michel Thierry wrote: > > There was no way to check if the platform is running the latest firmware. > > Cc: Tvrtko Ursulin [2] > Cc: Arkadiusz Hiler [3] > Sig

Re: [Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-23 Thread Kamble, Sagar A
Reviewed-by: Sagar Arun Kamble On 2/24/2017 4:41 AM, Michel Thierry wrote: There was no way to check if the platform is running the latest firmware. Cc: Tvrtko Ursulin Cc: Arkadiusz Hiler Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_gpu_error.c | 10 ++ 1 file chan

[Intel-gfx] [PATCH] drm/i915: Include GuC fw version in error state

2017-02-23 Thread Michel Thierry
There was no way to check if the platform is running the latest firmware. Cc: Tvrtko Ursulin Cc: Arkadiusz Hiler Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_gpu_error.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/driv