Re: [Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Ville Syrjälä
On Fri, Oct 07, 2016 at 08:00:35PM +0100, Chris Wilson wrote: > On Fri, Oct 07, 2016 at 07:57:21PM +0100, Chris Wilson wrote: > > On Fri, Oct 07, 2016 at 09:44:53PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 07, 2016 at 07:33:00PM +0100, Chris Wilson wrote: > > > > On Fri, Oct 07, 2016 at 09:06:

Re: [Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Chris Wilson
On Fri, Oct 07, 2016 at 07:57:21PM +0100, Chris Wilson wrote: > On Fri, Oct 07, 2016 at 09:44:53PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 07, 2016 at 07:33:00PM +0100, Chris Wilson wrote: > > > On Fri, Oct 07, 2016 at 09:06:07PM +0300, Ville Syrjälä wrote: > > > > On Fri, Oct 07, 2016 at 02:50

Re: [Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Chris Wilson
On Fri, Oct 07, 2016 at 09:44:53PM +0300, Ville Syrjälä wrote: > On Fri, Oct 07, 2016 at 07:33:00PM +0100, Chris Wilson wrote: > > On Fri, Oct 07, 2016 at 09:06:07PM +0300, Ville Syrjälä wrote: > > > On Fri, Oct 07, 2016 at 02:50:32PM +0100, Chris Wilson wrote: > > > > Whilst the vblank is configur

Re: [Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Ville Syrjälä
On Fri, Oct 07, 2016 at 07:33:00PM +0100, Chris Wilson wrote: > On Fri, Oct 07, 2016 at 09:06:07PM +0300, Ville Syrjälä wrote: > > On Fri, Oct 07, 2016 at 02:50:32PM +0100, Chris Wilson wrote: > > > Whilst the vblank is configured to send an interrupt everytime, we need > > > to keep the device awa

Re: [Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Chris Wilson
On Fri, Oct 07, 2016 at 09:06:07PM +0300, Ville Syrjälä wrote: > On Fri, Oct 07, 2016 at 02:50:32PM +0100, Chris Wilson wrote: > > Whilst the vblank is configured to send an interrupt everytime, we need > > to keep the device awake to process those interrupts. > > If we can enable vblanks the pipe

Re: [Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Ville Syrjälä
On Fri, Oct 07, 2016 at 02:50:32PM +0100, Chris Wilson wrote: > Whilst the vblank is configured to send an interrupt everytime, we need > to keep the device awake to process those interrupts. If we can enable vblanks the pipe will be active, and thus we can't runtime suspend anyway. Also might_sle

[Intel-gfx] [PATCH] drm/i915: Grab RPM wakeref around enabling vblank interrupts

2016-10-07 Thread Chris Wilson
Whilst the vblank is configured to send an interrupt everytime, we need to keep the device awake to process those interrupts. Reported-by: Anssi Hannula References: https://bugs.freedesktop.org/show_bug.cgi?id=97985 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 16 ++