Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-16 Thread Nirmoy Das
On 10/13/2023 6:15 PM, Daniel Vetter wrote: On Fri, Oct 13, 2023 at 02:28:21PM +0200, Nirmoy Das wrote: Hi Ville, On 10/13/2023 12:50 PM, Ville Syrjälä wrote: On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: gen8_ggtt_invalidate() is only needed for limitted set of platforms wher

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Daniel Vetter
On Fri, Oct 13, 2023 at 02:28:21PM +0200, Nirmoy Das wrote: > Hi Ville, > > On 10/13/2023 12:50 PM, Ville Syrjälä wrote: > > On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: > > > gen8_ggtt_invalidate() is only needed for limitted set of platforms > > > where GGTT is mapped as WC > > I

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Nirmoy Das
On 10/13/2023 2:55 PM, Ville Syrjälä wrote: On Fri, Oct 13, 2023 at 02:28:21PM +0200, Nirmoy Das wrote: Hi Ville, On 10/13/2023 12:50 PM, Ville Syrjälä wrote: On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: gen8_ggtt_invalidate() is only needed for limitted set of platforms wher

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Ville Syrjälä
On Fri, Oct 13, 2023 at 02:28:21PM +0200, Nirmoy Das wrote: > Hi Ville, > > On 10/13/2023 12:50 PM, Ville Syrjälä wrote: > > On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: > >> gen8_ggtt_invalidate() is only needed for limitted set of platforms > >> where GGTT is mapped as WC > > I kn

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Nirmoy Das
Hi Ville, On 10/13/2023 12:50 PM, Ville Syrjälä wrote: On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: gen8_ggtt_invalidate() is only needed for limitted set of platforms where GGTT is mapped as WC I know there is supposed to be some kind hw snooping of the ggtt pte writes to inval

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Ville Syrjälä
On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: > gen8_ggtt_invalidate() is only needed for limitted set of platforms > where GGTT is mapped as WC I know there is supposed to be some kind hw snooping of the ggtt pte writes to invalidate the tlb, but are we sure GFX_FLSH_CNTL has no oth

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Nirmoy Das
On 10/13/2023 12:35 PM, Andi Shyti wrote: Hi Nirmoy, On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: gen8_ggtt_invalidate() is only needed for limitted set of platforms /limitted/limited/ Added " autocmd FileType gitcommit setlocal spell" to my vim config. Wish I knew about it

Re: [Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Andi Shyti
Hi Nirmoy, On Fri, Oct 13, 2023 at 12:31:40PM +0200, Nirmoy Das wrote: > gen8_ggtt_invalidate() is only needed for limitted set of platforms /limitted/limited/ > where GGTT is mapped as WC otherwise this can cause unwanted > side-effects on XE_HP platforms where GFX_FLSH_CNTL_GEN6 is not > valid

[Intel-gfx] [PATCH] drm/i915: Flush WC GGTT only on required platforms

2023-10-13 Thread Nirmoy Das
gen8_ggtt_invalidate() is only needed for limitted set of platforms where GGTT is mapped as WC otherwise this can cause unwanted side-effects on XE_HP platforms where GFX_FLSH_CNTL_GEN6 is not valid. Fixes: d2eae8e98d59 ("drm/i915/dg2: Drop force_probe requirement") Cc: Rodrigo Vivi Cc: Tvrtko Ur