Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-24 Thread Jani Nikula
On Wed, 24 May 2017, Tvrtko Ursulin wrote: > On 23/05/2017 12:30, Jani Nikula wrote: >> On Tue, 23 May 2017, Tvrtko Ursulin wrote: >>> On 23/05/2017 10:56, Jani Nikula wrote: On Tue, 23 May 2017, Chris Wilson wrote: > On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-24 Thread Tvrtko Ursulin
On 23/05/2017 12:30, Jani Nikula wrote: On Tue, 23 May 2017, Tvrtko Ursulin wrote: On 23/05/2017 10:56, Jani Nikula wrote: On Tue, 23 May 2017, Chris Wilson wrote: On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Waiting for engines needs to happen eve

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Nick Desaulniers
Your patch also fixes the original warning reported in: https://lkml.org/lkml/2017/5/21/1 Signed-off-by: Nick Desaulniers ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Jani Nikula
On Tue, 23 May 2017, Tvrtko Ursulin wrote: > On 23/05/2017 10:56, Jani Nikula wrote: >> On Tue, 23 May 2017, Chris Wilson wrote: >>> On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Waiting for engines needs to happen even in the non-debug build

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Tvrtko Ursulin
On 23/05/2017 12:07, Chris Wilson wrote: On Tue, May 23, 2017 at 11:51:46AM +0100, Tvrtko Ursulin wrote: On 23/05/2017 11:30, Chris Wilson wrote: On Tue, May 23, 2017 at 11:09:17AM +0100, Chris Wilson wrote: On Tue, May 23, 2017 at 10:36:34AM +0100, Chris Wilson wrote: On Tue, May 23, 2017

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Chris Wilson
On Tue, May 23, 2017 at 11:51:46AM +0100, Tvrtko Ursulin wrote: > > On 23/05/2017 11:30, Chris Wilson wrote: > >On Tue, May 23, 2017 at 11:09:17AM +0100, Chris Wilson wrote: > >>On Tue, May 23, 2017 at 10:36:34AM +0100, Chris Wilson wrote: > >>>On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursu

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Tvrtko Ursulin
On 23/05/2017 11:30, Chris Wilson wrote: On Tue, May 23, 2017 at 11:09:17AM +0100, Chris Wilson wrote: On Tue, May 23, 2017 at 10:36:34AM +0100, Chris Wilson wrote: On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Waiting for engines needs to happen even

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Chris Wilson
On Tue, May 23, 2017 at 11:09:17AM +0100, Chris Wilson wrote: > On Tue, May 23, 2017 at 10:36:34AM +0100, Chris Wilson wrote: > > On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > Waiting for engines needs to happen even in the non-debug builds

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Chris Wilson
On Tue, May 23, 2017 at 10:36:34AM +0100, Chris Wilson wrote: > On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Waiting for engines needs to happen even in the non-debug builds > > so it is incorrect to wrap it in a GEM_WARN_ON. > > > > Call it un

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Tvrtko Ursulin
On 23/05/2017 10:56, Jani Nikula wrote: On Tue, 23 May 2017, Chris Wilson wrote: On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Waiting for engines needs to happen even in the non-debug builds so it is incorrect to wrap it in a GEM_WARN_ON. Call it unc

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Jani Nikula
On Tue, 23 May 2017, Chris Wilson wrote: > On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> Waiting for engines needs to happen even in the non-debug builds >> so it is incorrect to wrap it in a GEM_WARN_ON. >> >> Call it unconditionally and add GEM_

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Chris Wilson
On Tue, May 23, 2017 at 10:45:44AM +0100, Tvrtko Ursulin wrote: > > On 23/05/2017 10:29, Chris Wilson wrote: > >On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Waiting for engines needs to happen even in the non-debug builds > >>so it is incorrect

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Tvrtko Ursulin
On 23/05/2017 10:29, Chris Wilson wrote: On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Waiting for engines needs to happen even in the non-debug builds so it is incorrect to wrap it in a GEM_WARN_ON. Call it unconditionally and add GEM_WARN so that the

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Chris Wilson
On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Waiting for engines needs to happen even in the non-debug builds > so it is incorrect to wrap it in a GEM_WARN_ON. > > Call it unconditionally and add GEM_WARN so that the debug > warning can still be emit

Re: [Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Chris Wilson
On Tue, May 23, 2017 at 10:19:31AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Waiting for engines needs to happen even in the non-debug builds > so it is incorrect to wrap it in a GEM_WARN_ON. > > Call it unconditionally and add GEM_WARN so that the debug > warning can still be emit

[Intel-gfx] [PATCH] drm/i915: Fix waiting for engines to idle

2017-05-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Waiting for engines needs to happen even in the non-debug builds so it is incorrect to wrap it in a GEM_WARN_ON. Call it unconditionally and add GEM_WARN so that the debug warning can still be emitted when things go bad. Signed-off-by: Tvrtko Ursulin Fixes: 25112b64b3d2 ("