Re: [Intel-gfx] [PATCH] drm/i915: Fix up the forcewake timer initialization

2014-03-19 Thread Daniel Vetter
On Wed, Mar 19, 2014 at 8:26 AM, Chris Wilson wrote: > On Tue, Mar 18, 2014 at 05:41:54PM -0700, Ben Widawsky wrote: >> On Tue, Mar 18, 2014 at 04:31:03PM +0100, Daniel Vetter wrote: >> > This is a regression introduced in >> > >> > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd >> > Author: Chri

Re: [Intel-gfx] [PATCH] drm/i915: Fix up the forcewake timer initialization

2014-03-19 Thread Chris Wilson
On Tue, Mar 18, 2014 at 05:41:54PM -0700, Ben Widawsky wrote: > On Tue, Mar 18, 2014 at 04:31:03PM +0100, Daniel Vetter wrote: > > This is a regression introduced in > > > > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > > Author: Chris Wilson > > Date: Thu Mar 13 12:00:29 2014 + > > >

Re: [Intel-gfx] [PATCH] drm/i915: Fix up the forcewake timer initialization

2014-03-19 Thread Daniel Vetter
On Wed, Mar 19, 2014 at 1:41 AM, Ben Widawsky wrote: >> diff --git a/drivers/gpu/drm/i915/i915_dma.c >> b/drivers/gpu/drm/i915/i915_dma.c >> index e4d2b9f15ae2..9faee49f210d 100644 >> --- a/drivers/gpu/drm/i915/i915_dma.c >> +++ b/drivers/gpu/drm/i915/i915_dma.c >> @@ -1608,8 +1608,6 @@ int i915_

Re: [Intel-gfx] [PATCH] drm/i915: Fix up the forcewake timer initialization

2014-03-18 Thread Ben Widawsky
On Tue, Mar 18, 2014 at 04:31:03PM +0100, Daniel Vetter wrote: > This is a regression introduced in > > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > Author: Chris Wilson > Date: Thu Mar 13 12:00:29 2014 + > > drm/i915: Consolidate forcewake resetting to a single function > > The

[Intel-gfx] [PATCH] drm/i915: Fix up the forcewake timer initialization

2014-03-18 Thread Daniel Vetter
This is a regression introduced in commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd Author: Chris Wilson Date: Thu Mar 13 12:00:29 2014 + drm/i915: Consolidate forcewake resetting to a single function The reordered setup sequence ended up calling del_timer_sync before the timer was set