Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-07 Thread Lisovskiy, Stanislav
On Thu, Jul 06, 2023 at 09:02:29PM +0300, Ville Syrjälä wrote: > On Thu, Jul 06, 2023 at 01:32:17PM +0300, Lisovskiy, Stanislav wrote: > > On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > > > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > > > On Wed, Jul 05, 2

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2023 at 01:32:17PM +0300, Lisovskiy, Stanislav wrote: > On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > > > On Thu, May 25, 2023

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > > > According to BSpec 491

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Thu, Jul 06, 2023 at 11:47:26AM +0300, Imre Deak wrote: > On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > > > According to BSpec 491

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Imre Deak
On Thu, Jul 06, 2023 at 11:24:21AM +0300, Lisovskiy, Stanislav wrote: > On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > > According to BSpec 49190, when enabling crtcs, we first setup > > > slave and then master

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > According to BSpec 49190, when enabling crtcs, we first setup > > slave and then master crtc, however for disabling it should go > > vice versa, i.e first master, th

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-06 Thread Lisovskiy, Stanislav
On Wed, Jul 05, 2023 at 06:32:51PM +0300, Imre Deak wrote: > On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > > According to BSpec 49190, when enabling crtcs, we first setup > > slave and then master crtc, however for disabling it should go > > vice versa, i.e first master, th

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-05 Thread Imre Deak
On Thu, May 25, 2023 at 01:10:36PM +0300, Stanislav Lisovskiy wrote: > According to BSpec 49190, when enabling crtcs, we first setup > slave and then master crtc, however for disabling it should go > vice versa, i.e first master, then slave, however current code > does disabling in a same way as en

Re: [Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-07-05 Thread Luca Coelho
On Thu, 2023-05-25 at 13:10 +0300, Stanislav Lisovskiy wrote: > According to BSpec 49190, when enabling crtcs, we first setup > slave and then master crtc, however for disabling it should go > vice versa, i.e first master, then slave, however current code > does disabling in a same way as enabling.

[Intel-gfx] [PATCH] drm/i915: Fix the disabling sequence for Bigjoiner

2023-05-25 Thread Stanislav Lisovskiy
According to BSpec 49190, when enabling crtcs, we first setup slave and then master crtc, however for disabling it should go vice versa, i.e first master, then slave, however current code does disabling in a same way as enabling. Fix this, by skipping non-master crtcs, instead of non-slaves. Signe