Re: [Intel-gfx] [PATCH] drm/i915: Fix sprite offset on HSW

2012-10-26 Thread Paulo Zanoni
Hi 2012/10/25 Damien Lespiau : > From: Damien Lespiau > > HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET > register. > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_reg.h |3 +++ > drivers/gpu/drm/i915/intel_sprite.c | 18 +- > 2

Re: [Intel-gfx] [PATCH] drm/i915: Fix sprite offset on HSW

2012-10-26 Thread Chris Wilson
On Fri, 26 Oct 2012 10:33:00 +0300, Mika Kuoppala wrote: > On Thu, 25 Oct 2012 17:10:01 +0100, Damien Lespiau > wrote: > > @@ -127,13 +127,21 @@ ivb_update_plane(struct drm_plane *plane, struct > > drm_framebuffer *fb, > > > > I915_WRITE(SPRSTRIDE(pipe), fb->pitches[0]); > > I915_WRI

Re: [Intel-gfx] [PATCH] drm/i915: Fix sprite offset on HSW

2012-10-26 Thread Daniel Vetter
On Fri, Oct 26, 2012 at 9:33 AM, Mika Kuoppala wrote: > I don't know if upper layers sanitize already but > x should be < 8192 and y < 4096 in here, and both <4096 for ivb. > Emit warning and clamp if they are not in range? We probably need to do the same trick we're already doing in the main pla

Re: [Intel-gfx] [PATCH] drm/i915: Fix sprite offset on HSW

2012-10-26 Thread Mika Kuoppala
On Thu, 25 Oct 2012 17:10:01 +0100, Damien Lespiau wrote: > From: Damien Lespiau > > HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET > register. > > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_reg.h |3 +++ > drivers/gpu/drm/i915/intel_sprite.c |

[Intel-gfx] [PATCH] drm/i915: Fix sprite offset on HSW

2012-10-25 Thread Damien Lespiau
From: Damien Lespiau HSW consolidates SPRTILEOFF and SPRLINOFF into a single SPROFFSET register. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h |3 +++ drivers/gpu/drm/i915/intel_sprite.c | 18 +- 2 files changed, 16 insertions(+), 5 deletions(-) d