Re: [Intel-gfx] [PATCH] drm/i915: Fix set_caching locking

2012-09-26 Thread Daniel Vetter
On Wed, Sep 26, 2012 at 04:15:20PM -0700, Ben Widawsky wrote: > On the EINVAL case we don't release struct_mutex. It should be safe to > grab the lock after checking the parameters, which also resolves the > issues. > > Signed-off-by: Ben Widawsky Nice catch, thanks for the patch, applied to fix

[Intel-gfx] [PATCH] drm/i915: Fix set_caching locking

2012-09-26 Thread Ben Widawsky
On the EINVAL case we don't release struct_mutex. It should be safe to grab the lock after checking the parameters, which also resolves the issues. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/