Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 09:42:44PM +0100, Chris Wilson wrote: > On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The current pre-gen4 pipe off code might break out of the loop > > due to the timeout, but then the fail to print the warn

Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread Chris Wilson
On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The current pre-gen4 pipe off code might break out of the loop > due to the timeout, but then the fail to print the warning. > > Fix the issue by making sure we pair up the correct time compa

Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread Daniel Vetter
On Thu, Oct 10, 2013 at 08:32:23PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The current pre-gen4 pipe off code might break out of the loop > due to the timeout, but then the fail to print the warning. > > Fix the issue by making sure we pair up the correct time compa

[Intel-gfx] [PATCH] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-10 Thread ville . syrjala
From: Ville Syrjälä The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the fail to print the warning. Fix the issue by making sure we pair up the correct time comparison functions. It would be enough to change just the final check to use time_after_eq(),