Re: [Intel-gfx] [PATCH] drm/i915: Fix mode_get() for Broxton

2015-12-04 Thread Daniel Vetter
On Wed, Dec 02, 2015 at 11:09:34AM +0200, Ville Syrjälä wrote: > On Wed, Dec 02, 2015 at 12:13:27PM +0530, Vandana Kannan wrote: > > Making changes in intel_crtc_mode_get() to get correct values for crtc > > clock, > > vdisplay, hdisplay, vtotal. > > Why? It's not used except potentially during f

Re: [Intel-gfx] [PATCH] drm/i915: Fix mode_get() for Broxton

2015-12-02 Thread Jani Nikula
On Wed, 02 Dec 2015, Vandana Kannan wrote: > Making changes in intel_crtc_mode_get() to get correct values for crtc clock, > vdisplay, hdisplay, vtotal. > 1. intel_crtc_mode_get() gets clock using i9xx_crtc_clock_get() which wil not > work for hsw, skl, bxt. > 2. For BXT DSI, hdisplay, vdisplay, v

Re: [Intel-gfx] [PATCH] drm/i915: Fix mode_get() for Broxton

2015-12-02 Thread Ville Syrjälä
On Wed, Dec 02, 2015 at 12:13:27PM +0530, Vandana Kannan wrote: > Making changes in intel_crtc_mode_get() to get correct values for crtc clock, > vdisplay, hdisplay, vtotal. Why? It's not used except potentially during for DVO/LVDS init on old platforms. > 1. intel_crtc_mode_get() gets clock usin

[Intel-gfx] [PATCH] drm/i915: Fix mode_get() for Broxton

2015-12-01 Thread Vandana Kannan
Making changes in intel_crtc_mode_get() to get correct values for crtc clock, vdisplay, hdisplay, vtotal. 1. intel_crtc_mode_get() gets clock using i9xx_crtc_clock_get() which wil not work for hsw, skl, bxt. 2. For BXT DSI, hdisplay, vdisplay, vtotal registers are different. In the current implemen