Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-08 Thread Jani Nikula
On Thu, 04 Sep 2014, Daniel Vetter wrote: > On Thu, Sep 04, 2014 at 04:42:36PM +0300, Jani Nikula wrote: >> On Thu, 04 Sep 2014, Daniel Vetter wrote: >> > On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote: >> >> On Wed, 27 Aug 2014, Daniel Vetter wrote: >> >> > A bunch of warnings fire

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-05 Thread Jesse Barnes
On Wed, 27 Aug 2014 19:43:57 +0100 Chris Wilson wrote: > On Wed, Aug 27, 2014 at 10:11:34AM +0200, Daniel Vetter wrote: > > A bunch of warnings fire on some ->irq_postinstall hooks since those > > can enable interrupts (e.g. rps interrupts). And then our ordering > > self-checks fire and complain

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-04 Thread Daniel Vetter
On Thu, Sep 04, 2014 at 04:42:36PM +0300, Jani Nikula wrote: > On Thu, 04 Sep 2014, Daniel Vetter wrote: > > On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote: > >> On Wed, 27 Aug 2014, Daniel Vetter wrote: > >> > A bunch of warnings fire on some ->irq_postinstall hooks since those > >>

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-04 Thread Jani Nikula
On Thu, 04 Sep 2014, Daniel Vetter wrote: > On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote: >> On Wed, 27 Aug 2014, Daniel Vetter wrote: >> > A bunch of warnings fire on some ->irq_postinstall hooks since those >> > can enable interrupts (e.g. rps interrupts). And then our ordering >

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-04 Thread Daniel Vetter
On Thu, Sep 04, 2014 at 02:12:10PM +0300, Jani Nikula wrote: > On Wed, 27 Aug 2014, Daniel Vetter wrote: > > A bunch of warnings fire on some ->irq_postinstall hooks since those > > can enable interrupts (e.g. rps interrupts). And then our ordering > > self-checks fire and complain. > > > > To fix

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-04 Thread Jani Nikula
On Thu, 04 Sep 2014, Jani Nikula wrote: > On Wed, 27 Aug 2014, Daniel Vetter wrote: >> A bunch of warnings fire on some ->irq_postinstall hooks since those >> can enable interrupts (e.g. rps interrupts). And then our ordering >> self-checks fire and complain. >> >> To fix that set the tracking bo

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-09-04 Thread Jani Nikula
On Wed, 27 Aug 2014, Daniel Vetter wrote: > A bunch of warnings fire on some ->irq_postinstall hooks since those > can enable interrupts (e.g. rps interrupts). And then our ordering > self-checks fire and complain. > > To fix that set the tracking boolen before enabling the irqs witho > drm_irq_in

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-08-27 Thread Chris Wilson
On Wed, Aug 27, 2014 at 10:11:34AM +0200, Daniel Vetter wrote: > A bunch of warnings fire on some ->irq_postinstall hooks since those > can enable interrupts (e.g. rps interrupts). And then our ordering > self-checks fire and complain. > > To fix that set the tracking boolen before enabling the ir

Re: [Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-08-27 Thread Chris Wilson
On Wed, Aug 27, 2014 at 10:11:34AM +0200, Daniel Vetter wrote: > A bunch of warnings fire on some ->irq_postinstall hooks since those > can enable interrupts (e.g. rps interrupts). And then our ordering > self-checks fire and complain. > > To fix that set the tracking boolen before enabling the ir

[Intel-gfx] [PATCH] drm/i915: Fix irq enable tracking in driver load

2014-08-27 Thread Daniel Vetter
A bunch of warnings fire on some ->irq_postinstall hooks since those can enable interrupts (e.g. rps interrupts). And then our ordering self-checks fire and complain. To fix that set the tracking boolen before enabling the irqs with drm_irq_install. Quoting the discussion with Jesse why that's saf