Re: [Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Chris Wilson
Chia-I, I've pushed an updated version of the patch to -staging and added acks from both Kristian and Jesse since they both agreed with your assessment of the bug. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx maili

Re: [Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Kristian Høgsberg
On Thu, Oct 21, 2010 at 1:49 PM, Chia-I Wu wrote: > On Fri, Oct 22, 2010 at 12:18 AM, Jesse Barnes > wrote: >> On Thu, 21 Oct 2010 17:55:13 +0800 >> Chia-I Wu wrote: >> >>> Hi list, >>> >>> According to the doc for page_flip, intel_crtc_page_flip should >>> >>>    ... block all rendering to the

Re: [Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Jesse Barnes
On Fri, 22 Oct 2010 01:49:17 +0800 Chia-I Wu wrote: > On Fri, Oct 22, 2010 at 12:18 AM, Jesse Barnes > wrote: > > On Thu, 21 Oct 2010 17:55:13 +0800 > > Chia-I Wu wrote: > > > >> Hi list, > >> > >> According to the doc for page_flip, intel_crtc_page_flip should > >> > >>    ... block all rende

Re: [Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Chia-I Wu
On Fri, Oct 22, 2010 at 12:18 AM, Jesse Barnes wrote: > On Thu, 21 Oct 2010 17:55:13 +0800 > Chia-I Wu wrote: > >> Hi list, >> >> According to the doc for page_flip, intel_crtc_page_flip should >> >>    ... block all rendering to the current fb until the flip has >>    completed. >> >> I am not e

Re: [Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Jesse Barnes
On Thu, 21 Oct 2010 17:55:13 +0800 Chia-I Wu wrote: > Hi list, > > According to the doc for page_flip, intel_crtc_page_flip should > >... block all rendering to the current fb until the flip has >completed. > > I am not entirely sure, but it seems that it is > work->old_fb_obj->pending

Re: [Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Chris Wilson
On Thu, 21 Oct 2010 17:55:13 +0800, Chia-I Wu wrote: > Hi list, > > According to the doc for page_flip, intel_crtc_page_flip should > >... block all rendering to the current fb until the flip has >completed. > > I am not entirely sure, but it seems that it is > work->old_fb_obj->pending

[Intel-gfx] [PATCH] drm/i915: Fix current fb blocking for page flip.

2010-10-21 Thread Chia-I Wu
Hi list, According to the doc for page_flip, intel_crtc_page_flip should ... block all rendering to the current fb until the flip has completed. I am not entirely sure, but it seems that it is work->old_fb_obj->pending_flip that needs to be incremented instead of work->pending_flip_obj->pe