Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-05 Thread Dhinakaran Pandiyan
On Fri, 2018-10-05 at 11:10 -0700, Manasi Navare wrote: > On Thu, Oct 04, 2018 at 07:56:37PM -0700, Dhinakaran Pandiyan wrote: > > On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote: > > > On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > On Thu, 2018-10-04 at 1

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-05 Thread Manasi Navare
On Thu, Oct 04, 2018 at 07:56:37PM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote: > > On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote: > > > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > > > > On Thu, Oct 04, 2018 at 04:13

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 17:27 -0700, Manasi Navare wrote: > On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote: > > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > > > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > On Thu, 2018-10-04 at 1

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Manasi Navare
On Thu, Oct 04, 2018 at 05:00:06PM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote: > > > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > > > > On Thu, Oct 04, 2018 at 01:

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 16:28 -0700, Manasi Navare wrote: > On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote: > > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > > > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > The shifts for VSC_SE

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Manasi Navare
On Thu, Oct 04, 2018 at 04:13:26PM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > > > definitions are u

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Rodrigo Vivi
On Thu, Oct 04, 2018 at 04:03:05PM -0700, Lucas De Marchi wrote: > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > > definitions are unused. > > If they are unused why are we fixing them instead of remov

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
On Thu, 2018-10-04 at 16:03 -0700, Lucas De Marchi wrote: > On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > > definitions are unused. > > If they are unused why are we fixing them instead of removing? Or

Re: [Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Lucas De Marchi
On Thu, Oct 04, 2018 at 01:51:49PM -0700, Dhinakaran Pandiyan wrote: > The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the > definitions are unused. If they are unused why are we fixing them instead of removing? Or better, why did we add them? Lucas De Marchi > > Cc: Manasi Nava

[Intel-gfx] [PATCH] drm/i915: Fix VIDEO_DIP_CTL bit shifts

2018-10-04 Thread Dhinakaran Pandiyan
The shifts for VSC_SELECT bits are wrong, fix it. Good thing is the definitions are unused. Cc: Manasi Navare Cc: Anusha Srivatsa Cc: Rodrigo Vivi Fixes: 7af2be6d54d4 ("drm/i915/icl: Add VIDEO_DIP registers") Signed-off-by: Dhinakaran Pandiyan --- drivers/gpu/drm/i915/i915_reg.h | 18