Re: [Intel-gfx] [PATCH] drm/i915: Fix NULL plane->fb oops on SKL

2016-01-20 Thread Ville Syrjälä
On Tue, Jan 19, 2016 at 09:28:03PM +0100, Daniel Vetter wrote: > On Tue, Jan 19, 2016 at 06:23:17PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > In this atomic age, we can't trust the plane->fb pointer anymore. > > It might get update too late. Instead we are suppos

Re: [Intel-gfx] [PATCH] drm/i915: Fix NULL plane->fb oops on SKL

2016-01-19 Thread Daniel Vetter
On Tue, Jan 19, 2016 at 06:23:17PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > In this atomic age, we can't trust the plane->fb pointer anymore. > It might get update too late. Instead we are supposed to use the > plane_state->fb pointer instead. Let's do that in > intel

Re: [Intel-gfx] [PATCH] drm/i915: Fix NULL plane->fb oops on SKL

2016-01-19 Thread Ville Syrjälä
On Tue, Jan 19, 2016 at 04:30:48PM +, Tvrtko Ursulin wrote: > > On 19/01/16 16:23, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > In this atomic age, we can't trust the plane->fb pointer anymore. > > It might get update too late. Instead we are supposed to use the > > pl

Re: [Intel-gfx] [PATCH] drm/i915: Fix NULL plane->fb oops on SKL

2016-01-19 Thread Tvrtko Ursulin
On 19/01/16 16:23, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä In this atomic age, we can't trust the plane->fb pointer anymore. It might get update too late. Instead we are supposed to use the plane_state->fb pointer instead. Let's do that in intel_plane_obj_offset() and avoid pr

[Intel-gfx] [PATCH] drm/i915: Fix NULL plane->fb oops on SKL

2016-01-19 Thread ville . syrjala
From: Ville Syrjälä In this atomic age, we can't trust the plane->fb pointer anymore. It might get update too late. Instead we are supposed to use the plane_state->fb pointer instead. Let's do that in intel_plane_obj_offset() and avoid problems from dereferencing the potentially stale plane->fb p