Re: [Intel-gfx] [PATCH] drm/i915: Fix AVI/HDMI/SPD infoframes on HSW+

2015-12-16 Thread Ville Syrjälä
On Wed, Dec 16, 2015 at 05:15:18PM +0100, Daniel Vetter wrote: > On Wed, Dec 16, 2015 at 06:13:44PM +0200, Ville Syrjälä wrote: > > On Wed, Dec 16, 2015 at 06:10:00PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > I broke AVI/HDMI/SPD infoframes on HSW+ wit

Re: [Intel-gfx] [PATCH] drm/i915: Fix AVI/HDMI/SPD infoframes on HSW+

2015-12-16 Thread Daniel Vetter
On Wed, Dec 16, 2015 at 06:13:44PM +0200, Ville Syrjälä wrote: > On Wed, Dec 16, 2015 at 06:10:00PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > I broke AVI/HDMI/SPD infoframes on HSW+ with the register type > > safety changes. We were supposed to check that the inf

Re: [Intel-gfx] [PATCH] drm/i915: Fix AVI/HDMI/SPD infoframes on HSW+

2015-12-16 Thread Ville Syrjälä
On Wed, Dec 16, 2015 at 06:10:00PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > I broke AVI/HDMI/SPD infoframes on HSW+ with the register type > safety changes. We were supposed to check that the infoframe data > register is valid before writing the infoframe data, but th

[Intel-gfx] [PATCH] drm/i915: Fix AVI/HDMI/SPD infoframes on HSW+

2015-12-16 Thread ville . syrjala
From: Ville Syrjälä I broke AVI/HDMI/SPD infoframes on HSW+ with the register type safety changes. We were supposed to check that the infoframe data register is valid before writing the infoframe data, but the check ended up inverted, and so in practice we never wrote or enabled these infoframes.