Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-09-08 Thread Daniel Vetter
On Fri, Sep 05, 2014 at 02:12:49PM -0700, Rodrigo Vivi wrote: > As Paulo told the part 2 of his proposal is still missing and we will get > the WARN of reading fbc register at fbc_enabled when on runtime_suspend... > > But I couldn't find the propper place to check for intel_crtc->active. This > w

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-09-08 Thread Daniel Vetter
On Fri, Sep 05, 2014 at 12:35:18PM -0700, Rodrigo Vivi wrote: > On Fri, Sep 5, 2014 at 11:28 AM, Paulo Zanoni wrote: > > - The screen is disabled > > - We're runtime suspended > > > > These are another error. Not caused by this patch. > Why frontbuffer_flush is being called with screen disabled

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-09-05 Thread Rodrigo Vivi
As Paulo told the part 2 of his proposal is still missing and we will get the WARN of reading fbc register at fbc_enabled when on runtime_suspend... But I couldn't find the propper place to check for intel_crtc->active. This was another issue reported by power team that on screen off there was to

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-09-05 Thread Rodrigo Vivi
On Fri, Sep 5, 2014 at 11:28 AM, Paulo Zanoni wrote: > 2014-08-04 7:51 GMT-03:00 Rodrigo Vivi : > > According to spec FBC on BDW and HSW are identical without any gaps. > > So let's copy the nuke and let FBC really start compressing stuff. > > > > Without this patch we can verify with false color

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-09-05 Thread Paulo Zanoni
2014-08-04 7:51 GMT-03:00 Rodrigo Vivi : > According to spec FBC on BDW and HSW are identical without any gaps. > So let's copy the nuke and let FBC really start compressing stuff. > > Without this patch we can verify with false color that nothing is being > compressed. With the nuke in place and f

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 8:38 PM, Rodrigo Vivi wrote: > On Tue, Aug 26, 2014 at 12:54 AM, Daniel Vetter wrote: >> On Tue, Aug 26, 2014 at 2:39 AM, Rodrigo Vivi >> wrote: >> > So I prefer to continue using the HW/ring version we have already >> > working >> > for HSW and merge this v3 to get FBC w

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-26 Thread Rodrigo Vivi
On Tue, Aug 26, 2014 at 12:54 AM, Daniel Vetter wrote: > On Tue, Aug 26, 2014 at 2:39 AM, Rodrigo Vivi > wrote: > > So I prefer to continue using the HW/ring version we have already working > > for HSW and merge this v3 to get FBC working at BDW. > > Well for that we first need to fix up the psr

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 2:39 AM, Rodrigo Vivi wrote: > So I prefer to continue using the HW/ring version we have already working > for HSW and merge this v3 to get FBC working at BDW. Well for that we first need to fix up the psr testcase. I really want that. And then I also want fbc enabled by

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-25 Thread Rodrigo Vivi
I tried your suggestion for nuke fbc less... so I was just nuking along with psr_exit and cleaning the cache along with psr_do_enable and it got really better... I could see false colors working nice enough... However it got worst on PC7 residency... PC7 flutuated much more with the sw version...

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-21 Thread Rodrigo Vivi
List was accidentally drop. I didn't mean it. Sorry. And yes, you are right, we need a way to reduce nukes and cleans similar that we have for psr. I'll try it. On Tue, Aug 19, 2014 at 11:58 AM, Daniel Vetter wrote: > Readding intel-gfx. Please don't drop mailing lists cc's without telling > m

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-19 Thread Daniel Vetter
Readding intel-gfx. Please don't drop mailing lists cc's without telling me. Thanks, Daniel On Tue, Aug 19, 2014 at 8:57 PM, Daniel Vetter wrote: > Yeah, that does a lot too much flushing - you need to track relevant > dirty bits like psr does, and then only flush when there has been a > preceed

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-08 Thread Daniel Vetter
On Thu, Aug 07, 2014 at 01:04:19PM -0700, Rodrigo Vivi wrote: > I tested here on HSW a full sw nuke/cache clean and I didn't liked the > result. > It seems to compress less than the hw one and to recompress everything a > lot and stay less time compressed. That is really unexpected. For a modern d

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-07 Thread Rodrigo Vivi
I tested here on HSW a full sw nuke/cache clean and I didn't liked the result. It seems to compress less than the hw one and to recompress everything a lot and stay less time compressed. So, imho v3 is the way to go. On Mon, Aug 4, 2014 at 3:51 AM, Rodrigo Vivi wrote: > According to spec FBC o

[Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-04 Thread Rodrigo Vivi
According to spec FBC on BDW and HSW are identical without any gaps. So let's copy the nuke and let FBC really start compressing stuff. Without this patch we can verify with false color that nothing is being compressed. With the nuke in place and false color it is possible to see false color debug

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-04 Thread Daniel Vetter
On Fri, Aug 01, 2014 at 05:07:30PM +0300, Ville Syrjälä wrote: > On Thu, Jul 31, 2014 at 12:07:44PM -0700, Rodrigo Vivi wrote: > > According to spec FBC on BDW and HSW are identical without any gaps. > > So let's copy the nuke and let FBC really start compressing stuff. > > > > Without this patch

Re: [Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-08-01 Thread Ville Syrjälä
On Thu, Jul 31, 2014 at 12:07:44PM -0700, Rodrigo Vivi wrote: > According to spec FBC on BDW and HSW are identical without any gaps. > So let's copy the nuke and let FBC really start compressing stuff. > > Without this patch we can verify with false color that nothing is being > compressed. With t

[Intel-gfx] [PATCH] drm/i915: FBC flush nuke for BDW

2014-07-31 Thread Rodrigo Vivi
According to spec FBC on BDW and HSW are identical without any gaps. So let's copy the nuke and let FBC really start compressing stuff. Without this patch we can verify with false color that nothing is being compressed. With the nuke in place and false color it is possible to see false color debug