Re: [Intel-gfx] [PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Keith Packard
On Tue, 20 Sep 2011 17:24:21 +0100, Chris Wilson wrote: > On Tue, 20 Sep 2011 08:47:21 -0700, Keith Packard wrote: > > We were relying on the BIOS to set these bits, which doesn't always > > happen. > > Do we need to clear IRQ bits on uninstall, for example to prevent > "Interrupt 19: no one ca

Re: [Intel-gfx] [PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Chris Wilson
On Tue, 20 Sep 2011 08:47:21 -0700, Keith Packard wrote: > We were relying on the BIOS to set these bits, which doesn't always > happen. Do we need to clear IRQ bits on uninstall, for example to prevent "Interrupt 19: no one cared!" or is that due to a different cause? More of a general question

[Intel-gfx] [PATCH] drm/i915: Enable digital port hotplug on PCH systems

2011-09-20 Thread Keith Packard
We were relying on the BIOS to set these bits, which doesn't always happen. Signed-off-by: Keith Packard --- v2: set the hotplug bits in the irq post-install hook, just like we do for pre-PCH hardware. drivers/gpu/drm/i915/i915_irq.c | 24 drivers/gpu/drm/i915/i915_r