Re: [Intel-gfx] [PATCH] drm/i915: Don't need a timer to wake us up

2015-11-27 Thread Chris Wilson
On Fri, Nov 27, 2015 at 09:35:16AM +, Tvrtko Ursulin wrote: > > On 26/11/15 18:24, Chris Wilson wrote: > >On Thu, Nov 26, 2015 at 05:55:39PM +, Chris Wilson wrote: > >>On Thu, Nov 26, 2015 at 05:15:46PM +, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>Looks like the sleep

Re: [Intel-gfx] [PATCH] drm/i915: Don't need a timer to wake us up

2015-11-27 Thread Tvrtko Ursulin
On 26/11/15 18:24, Chris Wilson wrote: On Thu, Nov 26, 2015 at 05:55:39PM +, Chris Wilson wrote: On Thu, Nov 26, 2015 at 05:15:46PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Looks like the sleeping loop in __i915_wait_request can be simplified by using io_schedule_timeout instead

Re: [Intel-gfx] [PATCH] drm/i915: Don't need a timer to wake us up

2015-11-26 Thread Chris Wilson
On Thu, Nov 26, 2015 at 05:55:39PM +, Chris Wilson wrote: > On Thu, Nov 26, 2015 at 05:15:46PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Looks like the sleeping loop in __i915_wait_request can be > > simplified by using io_schedule_timeout instead of setting > > up and des

Re: [Intel-gfx] [PATCH] drm/i915: Don't need a timer to wake us up

2015-11-26 Thread Chris Wilson
On Thu, Nov 26, 2015 at 05:15:46PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Looks like the sleeping loop in __i915_wait_request can be > simplified by using io_schedule_timeout instead of setting > up and destroying a timer. Simplified by duplicating code? I liked the explicit han

[Intel-gfx] [PATCH] drm/i915: Don't need a timer to wake us up

2015-11-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Looks like the sleeping loop in __i915_wait_request can be simplified by using io_schedule_timeout instead of setting up and destroying a timer. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 28 1 file ch