Re: [Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-12 Thread Jani Nikula
On Mon, 10 Mar 2014, Ville Syrjälä wrote: > On Fri, Mar 07, 2014 at 08:34:46PM +0100, Daniel Vetter wrote: >> We need to enable interrupt processing before all the modeset >> state is set up. But that means we can fall over when we get a pipe >> underrun. This shouldn't happen as long as the bios

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-10 Thread Ville Syrjälä
On Fri, Mar 07, 2014 at 08:34:46PM +0100, Daniel Vetter wrote: > We need to enable interrupt processing before all the modeset > state is set up. But that means we can fall over when we get a pipe > underrun. This shouldn't happen as long as the bios works correctly > but as usual this turns out to

[Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-07 Thread Daniel Vetter
We need to enable interrupt processing before all the modeset state is set up. But that means we can fall over when we get a pipe underrun. This shouldn't happen as long as the bios works correctly but as usual this turns out to be wishful thinking. So disable error interrupts at irq install time

[Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-07 Thread Daniel Vetter
We need to enable interrupt processing before all the modeset state is set up. But that means we can fall over when we get a pipe underrun. This shouldn't happen as long as the bios works correctly but as usual this turns out to be wishful thinking. So disable error interrupts at irq install time

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-07 Thread Daniel Vetter
On Fri, Mar 7, 2014 at 7:24 PM, Ville Syrjälä wrote: > > I'll withold my r-b until we figure out what to do about the > "no full modeset"case ;) Atm that case doesn't really exist outside of fastboot=1. And that has the much larger issue of not updating the watermarks to our own power-optimized s

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-07 Thread Ville Syrjälä
On Fri, Mar 07, 2014 at 06:11:42PM +0100, Daniel Vetter wrote: > We need to enable interrupt processing before all the modeset > state is set up. But that means we can fall over when we get a pipe > underrun. This shouldn't happen as long as the bios works correctly > but as usual this turns out to

[Intel-gfx] [PATCH] drm/i915: Don't enable display error interrupts from the start

2014-03-07 Thread Daniel Vetter
We need to enable interrupt processing before all the modeset state is set up. But that means we can fall over when we get a pipe underrun. This shouldn't happen as long as the bios works correctly but as usual this turns out to be wishful thinking. So disable error interrupts at irq install time