Re: [Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-19 Thread Jani Nikula
On Mon, 19 Jun 2017, Dhinakaran Pandiyan wrote: > Maarten and Ville noticed that we are enabling backlight via DP aux very > early in the modeset_init path via the intel_dp_aux_setup_backlight() > function, since commit e7156c833903 ("drm/i915: Add Backlight Control using > DPCD for eDP connectors

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-19 Thread Pandiyan, Dhinakaran
On Mon, 2017-06-19 at 11:08 -0700, Dhinakaran Pandiyan wrote: > Maarten and Ville noticed that we are enabling backlight via DP aux very > early in the modeset_init path via the intel_dp_aux_setup_backlight() > function, since commit e7156c833903 ("drm/i915: Add Backlight Control using > DPCD for e

[Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-19 Thread Dhinakaran Pandiyan
Maarten and Ville noticed that we are enabling backlight via DP aux very early in the modeset_init path via the intel_dp_aux_setup_backlight() function, since commit e7156c833903 ("drm/i915: Add Backlight Control using DPCD for eDP connectors (v9)"). Looks like all we need to do during _setup_backl

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-13 Thread Pandiyan, Dhinakaran
On Tue, 2017-06-13 at 09:48 +0300, Jani Nikula wrote: > On Mon, 12 Jun 2017, Dhinakaran Pandiyan > wrote: > > Maarten and Ville noticed that we are enabling backlight via DP aux very > > early in the modeset_init path via the intel_dp_aux_setup_backlight() > > function. Looks like all we need to

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-13 Thread Pandiyan, Dhinakaran
On Tue, 2017-06-13 at 08:29 +0200, Maarten Lankhorst wrote: > Op 12-06-17 om 22:16 schreef Dhinakaran Pandiyan: > > Maarten and Ville noticed that we are enabling backlight via DP aux very > > early in the modeset_init path via the intel_dp_aux_setup_backlight() > > function. Looks like all we need

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-12 Thread Jani Nikula
On Mon, 12 Jun 2017, Dhinakaran Pandiyan wrote: > Maarten and Ville noticed that we are enabling backlight via DP aux very > early in the modeset_init path via the intel_dp_aux_setup_backlight() > function. Looks like all we need to do during _setup_backlight() is > read the current brightness sta

Re: [Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-12 Thread Maarten Lankhorst
Op 12-06-17 om 22:16 schreef Dhinakaran Pandiyan: > Maarten and Ville noticed that we are enabling backlight via DP aux very > early in the modeset_init path via the intel_dp_aux_setup_backlight() > function. Looks like all we need to do during _setup_backlight() is > read the current brightness st

[Intel-gfx] [PATCH] drm/i915: Don't enable backlight at setup time.

2017-06-12 Thread Dhinakaran Pandiyan
Maarten and Ville noticed that we are enabling backlight via DP aux very early in the modeset_init path via the intel_dp_aux_setup_backlight() function. Looks like all we need to do during _setup_backlight() is read the current brightness state instead of modifying it, so I don't why need to _enabl