Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-17 Thread Daniel Vetter
On Mon, Mar 17, 2014 at 01:17:32PM +, Chris Wilson wrote: > On Sat, Mar 15, 2014 at 11:30:18AM -0700, Ben Widawsky wrote: > > On Sat, Mar 15, 2014 at 03:20:23PM +, Chris Wilson wrote: > > > On Sat, Mar 15, 2014 at 12:47:22PM +0100, Daniel Vetter wrote: > > > > On Fri, Mar 14, 2014 at 05:21:

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-17 Thread Chris Wilson
On Sat, Mar 15, 2014 at 11:30:18AM -0700, Ben Widawsky wrote: > On Sat, Mar 15, 2014 at 03:20:23PM +, Chris Wilson wrote: > > On Sat, Mar 15, 2014 at 12:47:22PM +0100, Daniel Vetter wrote: > > > On Fri, Mar 14, 2014 at 05:21:36PM -0700, Ben Widawsky wrote: > > > > Broken by: > > > > commit 0294

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-17 Thread Daniel Vetter
On Mon, Mar 17, 2014 at 11:14:25AM +0200, Jani Nikula wrote: > On Mon, 17 Mar 2014, Jani Nikula wrote: > > On Sat, 15 Mar 2014, Ben Widawsky wrote: > >> Broken by: > >> commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > >> Author: Chris Wilson > >> Date: Thu Mar 13 12:00:29 2014 + > >> > >>

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-17 Thread Jani Nikula
On Mon, 17 Mar 2014, Jani Nikula wrote: > On Sat, 15 Mar 2014, Ben Widawsky wrote: >> Broken by: >> commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd >> Author: Chris Wilson >> Date: Thu Mar 13 12:00:29 2014 + >> >> drm/i915: Consolidate forcewake resetting to a single function >> > > Do

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-17 Thread Jani Nikula
On Sat, 15 Mar 2014, Ben Widawsky wrote: > Broken by: > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > Author: Chris Wilson > Date: Thu Mar 13 12:00:29 2014 + > > drm/i915: Consolidate forcewake resetting to a single function > Does this result in https://bugs.freedesktop.org/show_b

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-15 Thread Daniel Vetter
On Sat, Mar 15, 2014 at 7:30 PM, Ben Widawsky wrote: >> > > + setup_timer(&dev_priv->uncore.force_wake_timer, >> > > + gen6_force_wake_timer, (unsigned long)dev_priv); >> > >> > We call early_sanitize also from our resume code, so this will now >> > re-setup the timer again. We general

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-15 Thread Ben Widawsky
On Sat, Mar 15, 2014 at 03:20:23PM +, Chris Wilson wrote: > On Sat, Mar 15, 2014 at 12:47:22PM +0100, Daniel Vetter wrote: > > On Fri, Mar 14, 2014 at 05:21:36PM -0700, Ben Widawsky wrote: > > > Broken by: > > > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > > > Author: Chris Wilson > > > D

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-15 Thread Chris Wilson
On Sat, Mar 15, 2014 at 12:47:22PM +0100, Daniel Vetter wrote: > On Fri, Mar 14, 2014 at 05:21:36PM -0700, Ben Widawsky wrote: > > Broken by: > > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > > Author: Chris Wilson > > Date: Thu Mar 13 12:00:29 2014 + > > > > drm/i915: Consolidate f

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-15 Thread Daniel Vetter
On Fri, Mar 14, 2014 at 05:21:36PM -0700, Ben Widawsky wrote: > Broken by: > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > Author: Chris Wilson > Date: Thu Mar 13 12:00:29 2014 + > > drm/i915: Consolidate forcewake resetting to a single function > > Cc: Chris Wilson > Cc: Mika Kuo

[Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-15 Thread Ben Widawsky
Broken by: commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd Author: Chris Wilson Date: Thu Mar 13 12:00:29 2014 + drm/i915: Consolidate forcewake resetting to a single function Cc: Chris Wilson Cc: Mika Kuoppala Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_uncore.c | 6

Re: [Intel-gfx] [PATCH] drm/i915: Don't del_timer_sync uninitialized timer

2014-03-15 Thread Chris Wilson
On Fri, Mar 14, 2014 at 05:21:36PM -0700, Ben Widawsky wrote: > Broken by: > commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd > Author: Chris Wilson > Date: Thu Mar 13 12:00:29 2014 + > > drm/i915: Consolidate forcewake resetting to a single function as it is now called by intel_uncore_