Re: [Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

2015-07-16 Thread Bob Paauwe
On Thu, 16 Jul 2015 13:30:11 +0100 Damien Lespiau wrote: > On Wed, Jul 08, 2015 at 09:05:53AM -0700, Bob Paauwe wrote: > > Clearing the watermarks for all pipes/planes when updating the > > watermarks for a single CRTC change seems like the wrong thing to > > do here. As is, this code will update

Re: [Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

2015-07-16 Thread Damien Lespiau
On Wed, Jul 08, 2015 at 09:05:53AM -0700, Bob Paauwe wrote: > Clearing the watermarks for all pipes/planes when updating the > watermarks for a single CRTC change seems like the wrong thing to > do here. As is, this code will update any pipe/plane watermarks > that need updating and leave the remai

Re: [Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

2015-07-16 Thread Damien Lespiau
On Wed, Jul 08, 2015 at 09:05:53AM -0700, Bob Paauwe wrote: > Clearing the watermarks for all pipes/planes when updating the > watermarks for a single CRTC change seems like the wrong thing to > do here. As is, this code will update any pipe/plane watermarks > that need updating and leave the remai

Re: [Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

2015-07-08 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6753 -Summary- Platform Delta drm-intel-nightly Series Applied ILK

[Intel-gfx] [PATCH] drm/i915: Don't clear all watermarks when updating.

2015-07-08 Thread Bob Paauwe
Clearing the watermarks for all pipes/planes when updating the watermarks for a single CRTC change seems like the wrong thing to do here. As is, this code will update any pipe/plane watermarks that need updating and leave the remaining set to zero. Later, the watermark checks in check_wm_state() w