Re: [Intel-gfx] [PATCH] drm/i915: Do not put big intel_crtc_state on the stack

2016-01-21 Thread Jani Nikula
On Tue, 19 Jan 2016, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Having this on stack triggers the -Wframe-larger-than=1024 and > is not nice to put such big things on the kernel stack anyway. > > This required a little bit of refactoring to handle the new > failure path from vlv_force_pll_o

Re: [Intel-gfx] [PATCH] drm/i915: Do not put big intel_crtc_state on the stack

2016-01-20 Thread Tvrtko Ursulin
On 19/01/16 20:22, Daniel Vetter wrote: On Tue, Jan 19, 2016 at 03:25:17PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway. This required a little bit of refactoring

Re: [Intel-gfx] [PATCH] drm/i915: Do not put big intel_crtc_state on the stack

2016-01-19 Thread Daniel Vetter
On Tue, Jan 19, 2016 at 03:25:17PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Having this on stack triggers the -Wframe-larger-than=1024 and > is not nice to put such big things on the kernel stack anyway. > > This required a little bit of refactoring to handle the new > failure pat

[Intel-gfx] [PATCH] drm/i915: Do not put big intel_crtc_state on the stack

2016-01-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Having this on stack triggers the -Wframe-larger-than=1024 and is not nice to put such big things on the kernel stack anyway. This required a little bit of refactoring to handle the new failure path from vlv_force_pll_on. Signed-off-by: Tvrtko Ursulin Cc: Daniel Vetter Cc