Re: [Intel-gfx] [PATCH] drm/i915: Do not leak pages when freeing userptr objects

2014-09-29 Thread Daniel Vetter
On Fri, Sep 26, 2014 at 03:55:51PM +0100, Chris Wilson wrote: > On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > sg_alloc_table_from_pages() can build us a table with coalesced ranges which > > means we need to iterate over pages and not sg table en

Re: [Intel-gfx] [PATCH] drm/i915: Do not leak pages when freeing userptr objects

2014-09-29 Thread Jani Nikula
On Fri, 26 Sep 2014, Chris Wilson wrote: > On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> sg_alloc_table_from_pages() can build us a table with coalesced ranges which >> means we need to iterate over pages and not sg table entries when releasing >>

Re: [Intel-gfx] [PATCH] drm/i915: Do not leak pages when freeing userptr objects

2014-09-26 Thread Chris Wilson
On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > sg_alloc_table_from_pages() can build us a table with coalesced ranges which > means we need to iterate over pages and not sg table entries when releasing > page references. > > Signed-off-by: Tvrtko Ursul

Re: [Intel-gfx] [PATCH] drm/i915: Do not leak pages when freeing userptr objects

2014-09-26 Thread Barbalho, Rafael
> -Original Message- > From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] > Sent: Friday, September 26, 2014 3:05 PM > To: Intel-gfx@lists.freedesktop.org > Cc: Ursulin, Tvrtko; Chris Wilson; Barbalho, Rafael > Subject: [PATCH] drm/i915: Do not leak pages when freeing userptr obje

[Intel-gfx] [PATCH] drm/i915: Do not leak pages when freeing userptr objects

2014-09-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin sg_alloc_table_from_pages() can build us a table with coalesced ranges which means we need to iterate over pages and not sg table entries when releasing page references. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson Cc: "Barbalho, Rafael" --- drivers/gpu/drm/i915/i915_g