Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-24 Thread Jani Nikula
On Tue, 10 Feb 2015, Jani Nikula wrote: > On Mon, 09 Feb 2015, Daniel Vetter wrote: >> From: Chris Wilson >> >> This (partially) reverts >> >> commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd >> Author: Chris Wilson >> Date: Tue Mar 25 13:23:06 2014 + >> >> drm/i915: Invalidate our pag

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-20 Thread Sean V Kelley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/11/2015 05:02 AM, Daniel Vetter wrote: > On Wed, Feb 11, 2015 at 1:55 AM, Sean V Kelley > wrote: >> No corruption seen. I will add reloc domains to my growing audit >> list. > > One more for the libva audit list: > > If you do any ioctl dir

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-11 Thread Daniel Vetter
On Wed, Feb 11, 2015 at 1:55 AM, Sean V Kelley wrote: > No corruption seen. I will add reloc domains to my growing audit list. One more for the libva audit list: If you do any ioctl directly, please make sure that you clear the ioctl structure with memset(&arg, 0, sizeof(arg)); or similar. Othe

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-10 Thread Sean V Kelley
On 02/09/2015 08:46 AM, Chris Wilson wrote: > On Sun, Feb 08, 2015 at 03:27:13PM -0800, Sean V Kelley wrote: >> >> >> On 01/16/2015 08:05 PM, Daniel Vetter wrote: >>> On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote: On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote:

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-10 Thread Jani Nikula
On Mon, 09 Feb 2015, Daniel Vetter wrote: > From: Chris Wilson > > This (partially) reverts > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd > Author: Chris Wilson > Date: Tue Mar 25 13:23:06 2014 + > > drm/i915: Invalidate our pages under memory pressure > > It appears given the ri

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-10 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5733 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 282/283

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-09 Thread Sean V Kelley
On 02/09/2015 08:46 AM, Chris Wilson wrote: > On Sun, Feb 08, 2015 at 03:27:13PM -0800, Sean V Kelley wrote: >> >> >> On 01/16/2015 08:05 PM, Daniel Vetter wrote: >>> On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote: On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-09 Thread Chris Wilson
On Sun, Feb 08, 2015 at 03:27:13PM -0800, Sean V Kelley wrote: > > > On 01/16/2015 08:05 PM, Daniel Vetter wrote: > > On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote: > >> On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote: > >>> On Wed, Jan 14, 2015 at 9:34 PM, Chris Wils

[Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-09 Thread Daniel Vetter
From: Chris Wilson This (partially) reverts commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd Author: Chris Wilson Date: Tue Mar 25 13:23:06 2014 + drm/i915: Invalidate our pages under memory pressure It appears given the right workload, that pages which are swapped out more than once

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-08 Thread Sean V Kelley
On 01/16/2015 08:05 PM, Daniel Vetter wrote: > On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote: >> On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote: >>> On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson >>> wrote: This (partially) reverts commit 5537252b6b6d

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-16 Thread Daniel Vetter
On Thu, Jan 15, 2015 at 08:44:00PM +, Chris Wilson wrote: > On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote: > > On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson > > wrote: > > > This (partially) reverts > > > > > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd > > > Author: Chri

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-15 Thread Chris Wilson
On Thu, Jan 15, 2015 at 08:36:15PM +0100, Daniel Vetter wrote: > On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson > wrote: > > This (partially) reverts > > > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd > > Author: Chris Wilson > > Date: Tue Mar 25 13:23:06 2014 + > > > > drm/i915: I

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-15 Thread Daniel Vetter
On Wed, Jan 14, 2015 at 9:34 PM, Chris Wilson wrote: > This (partially) reverts > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd > Author: Chris Wilson > Date: Tue Mar 25 13:23:06 2014 + > > drm/i915: Invalidate our pages under memory pressure Shouldn't we also revert the hunk in i9

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-15 Thread Chris Wilson
On Thu, Jan 15, 2015 at 01:55:52AM +0100, Daniel Vetter wrote: > On Wed, Jan 14, 2015 at 08:34:31PM +, Chris Wilson wrote: > > This (partially) reverts > > > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd > > Author: Chris Wilson > > Date: Tue Mar 25 13:23:06 2014 + > > > > drm/i9

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-14 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5582 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-14 Thread Sean V Kelley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/14/2015 04:55 PM, Daniel Vetter wrote: > On Wed, Jan 14, 2015 at 08:34:31PM +, Chris Wilson wrote: >> This (partially) reverts >> >> commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd Author: Chris >> Wilson Date: Tue Mar 25 13:23:06 >> 20

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-14 Thread Daniel Vetter
On Wed, Jan 14, 2015 at 08:34:31PM +, Chris Wilson wrote: > This (partially) reverts > > commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd > Author: Chris Wilson > Date: Tue Mar 25 13:23:06 2014 + > > drm/i915: Invalidate our pages under memory pressure > > It appears given the right w

[Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-01-14 Thread Chris Wilson
This (partially) reverts commit 5537252b6b6d71fb1a8ed7395a8e5babf91953fd Author: Chris Wilson Date: Tue Mar 25 13:23:06 2014 + drm/i915: Invalidate our pages under memory pressure It appears given the right workload, that pages which are swapped out more than once are incorrectly inva