Re: [Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-08 Thread Chris Wilson
On Thu, Aug 08, 2013 at 08:43:30AM +0200, Daniel Vetter wrote: > On Thu, Aug 8, 2013 at 1:25 AM, Chris Wilson wrote: > > On Thu, Aug 08, 2013 at 01:18:18AM +0200, Daniel Vetter wrote: > >> Afaict the request holds a ref on the context, and that a ref on the hw > >> context bo. But the active list

Re: [Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-07 Thread Daniel Vetter
On Thu, Aug 8, 2013 at 1:25 AM, Chris Wilson wrote: > On Thu, Aug 08, 2013 at 01:18:18AM +0200, Daniel Vetter wrote: >> Afaict the request holds a ref on the context, and that a ref on the hw >> context bo. But the active list itself (thanks to the move_to_active) >> should also hold a ref to the

Re: [Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-07 Thread Chris Wilson
On Thu, Aug 08, 2013 at 01:18:18AM +0200, Daniel Vetter wrote: > Afaict the request holds a ref on the context, and that a ref on the hw > context bo. But the active list itself (thanks to the move_to_active) > should also hold a ref to the hw context bo, so I don't think we really > need full requ

Re: [Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-07 Thread Daniel Vetter
On Thu, Aug 08, 2013 at 12:10:22AM +0100, Chris Wilson wrote: > On Wed, Aug 07, 2013 at 11:58:21PM +0200, Daniel Vetter wrote: > > On Wed, Aug 07, 2013 at 10:29:05PM +0100, Chris Wilson wrote: > > > We use the request to ensure we hold a reference to the context for the > > > duration that it remai

Re: [Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-07 Thread Chris Wilson
On Wed, Aug 07, 2013 at 11:58:21PM +0200, Daniel Vetter wrote: > On Wed, Aug 07, 2013 at 10:29:05PM +0100, Chris Wilson wrote: > > We use the request to ensure we hold a reference to the context for the > > duration that it remains in use by the ring. Each request only holds a > > reference to the

Re: [Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-07 Thread Daniel Vetter
On Wed, Aug 07, 2013 at 10:29:05PM +0100, Chris Wilson wrote: > We use the request to ensure we hold a reference to the context for the > duration that it remains in use by the ring. Each request only holds a > reference to the current context, hence we emit a request after > switching contexts wit

[Intel-gfx] [PATCH] drm/i915: Do not add an interrupt for a context switch

2013-08-07 Thread Chris Wilson
We use the request to ensure we hold a reference to the context for the duration that it remains in use by the ring. Each request only holds a reference to the current context, hence we emit a request after switching contexts with the final reference to the old context. However, the extra interrupt