Re: [Intel-gfx] [PATCH] drm/i915: Detect the error case for too large CRTC offsets

2012-07-05 Thread Olivier Galibert
On Thu, Jul 05, 2012 at 10:10:10AM +0100, Chris Wilson wrote: > + if (INTEL_INFO(dev)->gen >= 4 && (x|y) & ~4095) { > + DRM_ERROR("CRTC offset too larget (%d, %d)\n", x, y); larget? OG. ___ Intel-gfx mailing list Intel-gfx@lists.freede

Re: [Intel-gfx] [PATCH] drm/i915: Detect the error case for too large CRTC offsets

2012-07-05 Thread Chris Wilson
On Thu, 5 Jul 2012 19:22:37 +0200, Olivier Galibert wrote: > On Thu, Jul 05, 2012 at 10:10:10AM +0100, Chris Wilson wrote: > > + if (INTEL_INFO(dev)->gen >= 4 && (x|y) & ~4095) { > > + DRM_ERROR("CRTC offset too larget (%d, %d)\n", x, y); > > larget? Not even a humorous typo. Daniel

[Intel-gfx] [PATCH] drm/i915: Detect the error case for too large CRTC offsets

2012-07-05 Thread Chris Wilson
On gen4+, we program the CRTC offset into the DSPTILEOFF register, which is limited to 12-bits of integer precision in both the x and the y axes. Programming a value larger than or equal to 4096 results in a wraparound of the CRTC location and a distorted output. This is undesirable, so abort the o