Re: [Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-28 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5843 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 282/282

Re: [Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-27 Thread Quentin Casasnovas
On Thu, Feb 26, 2015 at 05:10:17PM +, Chris Wilson wrote: > Not all of the DVO functions were checking the return value from their > i2c routines when reading registers. This could lead to us feeding > garbage values back into the hardware, possible causing further > failures. In some cases the

Re: [Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-27 Thread Quentin Casasnovas
On Thu, Feb 26, 2015 at 10:09:49PM +, Chris Wilson wrote: > On Thu, Feb 26, 2015 at 06:47:14PM +0100, Quentin Casasnovas wrote: > > On Thu, Feb 26, 2015 at 05:10:17PM +, Chris Wilson wrote: > > > Not all of the DVO functions were checking the return value from their > > > i2c routines when

Re: [Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 06:47:14PM +0100, Quentin Casasnovas wrote: > On Thu, Feb 26, 2015 at 05:10:17PM +, Chris Wilson wrote: > > Not all of the DVO functions were checking the return value from their > > i2c routines when reading registers. This could lead to us feeding > > garbage values ba

[Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-26 Thread Chris Wilson
Not all of the DVO functions were checking the return value from their i2c routines when reading registers. This could lead to us feeding garbage values back into the hardware, possible causing further failures. In some cases the uninitialised stack values were being written into the kernel log. Q