Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-05 Thread Daniel Vetter
On Thu, Sep 5, 2013 at 4:51 PM, Thomas Richter wrote: > Am 02.09.2013 16:18, schrieb Daniel Vetter: >> >> Hm, I've probably botched the watermarks again. Can you please retest with >> the below diff? >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c >> b/drivers/gpu/drm/i915/intel_pm.c >> index d

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-05 Thread Thomas Richter
Am 02.09.2013 16:18, schrieb Daniel Vetter: Hm, I've probably botched the watermarks again. Can you please retest with the below diff? diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index dfdc7ad..b667ff0 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-02 Thread Thomas Richter
On 02.09.2013 16:18, Daniel Vetter wrote: Checked with the above modifications. Unfortunately, the result is negative. With the above modifications and my changes commented out, the screen flickers in normal state (without panning) but in a different way: With the above enabled, you get a rather

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-02 Thread Ville Syrjälä
On Mon, Sep 02, 2013 at 03:58:59PM +0200, Thomas Richter wrote: > Hi Daniel, > > > I've just looked at the docs and they only mention that the base address > > must be pixel aligned. But it could very well be that the watermarks are a > > bit off for your chipset. The below quick hack should test

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-02 Thread Daniel Vetter
On Mon, Sep 02, 2013 at 03:58:59PM +0200, Thomas Richter wrote: > Hi Daniel, > > >I've just looked at the docs and they only mention that the base address > >must be pixel aligned. But it could very well be that the watermarks are a > >bit off for your chipset. The below quick hack should test thi

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-02 Thread Ville Syrjälä
On Mon, Sep 02, 2013 at 09:10:22AM +0200, Daniel Vetter wrote: > On Sun, Sep 01, 2013 at 07:01:49PM +0200, Thomas Richter wrote: > > Dear intel-gfx developers, > > > > When panning is enabled on the 830GM, horizontal panning creates a > > lot of flickering on specific pixel positions. > > After te

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-02 Thread Thomas Richter
Hi Daniel, I've just looked at the docs and they only mention that the base address must be pixel aligned. But it could very well be that the watermarks are a bit off for your chipset. The below quick hack should test this theory. -Daniel diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/

Re: [Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-02 Thread Daniel Vetter
On Sun, Sep 01, 2013 at 07:01:49PM +0200, Thomas Richter wrote: > Dear intel-gfx developers, > > When panning is enabled on the 830GM, horizontal panning creates a > lot of flickering on specific pixel positions. > After testing, I found that the reason for this is that panning > works by altering

[Intel-gfx] [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM

2013-09-01 Thread Thomas Richter
Dear intel-gfx developers, When panning is enabled on the 830GM, horizontal panning creates a lot of flickering on specific pixel positions. After testing, I found that the reason for this is that panning works by altering the frame origin pointer, which, however, has certain alignment restrict