Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Zhi Wang
Thanks! :D Thanks, Zhi. 于 06/25/15 21:42, Chris Wilson 写道: On Thu, Jun 25, 2015 at 05:56:58AM +0800, Zhi Wang wrote: Hi Chris: Thanks for the reply! I just dig the code. It looks there is no special code path for execlist shutdown. It has init_rings(), but doesn't have cleanup_rings(), on

Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Chris Wilson
On Thu, Jun 25, 2015 at 05:56:58AM +0800, Zhi Wang wrote: > Hi Chris: > Thanks for the reply! I just dig the code. It looks there is no > special code path for execlist shutdown. It has init_rings(), but > doesn't have cleanup_rings(), only clean_ring(), which are called > for each ring one by

Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Zhi Wang
Hi Chris: Thanks for the reply! I just dig the code. It looks there is no special code path for execlist shutdown. It has init_rings(), but doesn't have cleanup_rings(), only clean_ring(), which are called for each ring one by one when i915_gem_cleanup_ringbuffer() gets called. Do you hav

Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Daniel Vetter
On Thu, Jun 25, 2015 at 09:13:13AM +0100, Chris Wilson wrote: > On Thu, Jun 25, 2015 at 10:40:15PM +0800, bing@intel.com wrote: > > From: "Niu,Bing" > > > > It is found that i915 will not reset gpu under execlist mode when > > unload module. that will lead to some issues when unload/load modu

Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Chris Wilson
On Thu, Jun 25, 2015 at 12:24:59PM +, Wang, Zhi A wrote: > Hi Chris: > Thanks for the comments that extends our knowledge about this > modification. Really appreciate the help. But is it possible that we still > need an ordinary gpu reset here? Consider that we may modprobe i915 with > i

Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Wang, Zhi A
Niu, Bing > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under > execlist > mode. > > On Thu, Jun 25, 2015 at 10:40:15PM +0800, bing@intel.com wrote: > > From: "Niu,Bing" > > > > It i

Re: [Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-25 Thread Chris Wilson
On Thu, Jun 25, 2015 at 10:40:15PM +0800, bing@intel.com wrote: > From: "Niu,Bing" > > It is found that i915 will not reset gpu under execlist mode when > unload module. that will lead to some issues when unload/load module > with different submission mode. e.g. from execlist mode to ring > b

[Intel-gfx] [PATCH] drm/i915: Also perform gpu reset under execlist mode.

2015-06-24 Thread bing . niu
From: "Niu,Bing" It is found that i915 will not reset gpu under execlist mode when unload module. that will lead to some issues when unload/load module with different submission mode. e.g. from execlist mode to ring buffer mode via loading/unloading i915. Because HW is not in a reset state and re