Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-03 Thread Rodrigo Vivi
On Thu, May 03, 2018 at 04:17:24PM +0300, Ville Syrjälä wrote: > On Thu, May 03, 2018 at 06:07:45AM -0700, Rodrigo Vivi wrote: > > On Wed, May 02, 2018 at 10:12:51PM +0300, Ville Syrjälä wrote: > > > On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > > > > On intel_dp_compute_config()

Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 06:07:45AM -0700, Rodrigo Vivi wrote: > On Wed, May 02, 2018 at 10:12:51PM +0300, Ville Syrjälä wrote: > > On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > > > On intel_dp_compute_config() we were calculating the needed vco > > > for eDP on gen9 and we stashin

Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-03 Thread Rodrigo Vivi
On Wed, May 02, 2018 at 10:12:51PM +0300, Ville Syrjälä wrote: > On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > > On intel_dp_compute_config() we were calculating the needed vco > > for eDP on gen9 and we stashing it in > > intel_atomic_state.cdclk.logical.vco > > > > However few

Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-02 Thread Ville Syrjälä
On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > On intel_dp_compute_config() we were calculating the needed vco > for eDP on gen9 and we stashing it in > intel_atomic_state.cdclk.logical.vco > > However few moments later on intel_modeset_checks() we fully > replace entire intel_ato

[Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-02 Thread Rodrigo Vivi
On intel_dp_compute_config() we were calculating the needed vco for eDP on gen9 and we stashing it in intel_atomic_state.cdclk.logical.vco However few moments later on intel_modeset_checks() we fully replace entire intel_atomic_state.cdclk.logical with dev_priv->cdclk.logical fully overwriting the