Re: [Intel-gfx] [PATCH] drm/i915: Add some curly braces

2016-08-09 Thread Ville Syrjälä
On Fri, Aug 05, 2016 at 06:49:26PM +0100, Chris Wilson wrote: > On Fri, Aug 05, 2016 at 08:41:34PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_enable_pipe() looks rather confusing when one side doesn't have > > the curly braces, and the other one does. And wh

Re: [Intel-gfx] [PATCH] drm/i915: Add some curly braces

2016-08-05 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-05 at 18:49 +0100, Chris Wilson wrote: > On Fri, Aug 05, 2016 at 08:41:34PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_enable_pipe() looks rather confusing when one side doesn't have > > the curly braces, and the other one does. And what's ev

Re: [Intel-gfx] [PATCH] drm/i915: Add some curly braces

2016-08-05 Thread Chris Wilson
On Fri, Aug 05, 2016 at 08:41:34PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > intel_enable_pipe() looks rather confusing when one side doesn't have > the curly braces, and the other one does. And what's even worse, > there's another if-else inside the braceless side. Le

[Intel-gfx] [PATCH] drm/i915: Add some curly braces

2016-08-05 Thread ville . syrjala
From: Ville Syrjälä intel_enable_pipe() looks rather confusing when one side doesn't have the curly braces, and the other one does. And what's even worse, there's another if-else inside the braceless side. Let's put braces around it to make it clear which branch goes where. Signed-off-by: Ville