Re: [Intel-gfx] [PATCH] drm/i915: Add secure batch ggtt vma as active during execution

2014-09-11 Thread Chris Wilson
On Thu, Sep 11, 2014 at 09:30:27AM -0700, Volkin, Bradley D wrote: > On Thu, Sep 11, 2014 at 01:49:07AM -0700, Chris Wilson wrote: > > vma->exec_entry = memset(&dummy_exec_entry, 0, sizeof(dummy_exec_entry); > > > > Then you can kill the additional if (entry) checks. > > Also, don't we need to se

Re: [Intel-gfx] [PATCH] drm/i915: Add secure batch ggtt vma as active during execution

2014-09-11 Thread Volkin, Bradley D
On Thu, Sep 11, 2014 at 01:49:07AM -0700, Chris Wilson wrote: > On Thu, Sep 11, 2014 at 11:39:46AM +0300, Mika Kuoppala wrote: > > When PPGGT is in use, we need to bind secure batches also to ggtt. > > We used to pin, exec and unpin. This trick worked as there was nothing > > competing in ggtt spac

Re: [Intel-gfx] [PATCH] drm/i915: Add secure batch ggtt vma as active during execution

2014-09-11 Thread Chris Wilson
On Thu, Sep 11, 2014 at 11:39:46AM +0300, Mika Kuoppala wrote: > When PPGGT is in use, we need to bind secure batches also to ggtt. > We used to pin, exec and unpin. This trick worked as there was nothing > competing in ggtt space and the ppggt vma was used to tracking. > But this left the ggtt vma

[Intel-gfx] [PATCH] drm/i915: Add secure batch ggtt vma as active during execution

2014-09-11 Thread Mika Kuoppala
When PPGGT is in use, we need to bind secure batches also to ggtt. We used to pin, exec and unpin. This trick worked as there was nothing competing in ggtt space and the ppggt vma was used to tracking. But this left the ggtt vma untracked and potentially it could vanish during the batch execution.