Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Friday, May 03, 2013 10:27 PM > To: Barnes, Jesse > Cc: Daniel Vetter; Wang, Xingchao; Li, Jocelyn; Daniel Vetter; Zanoni, Paulo > R; > ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, Liam R; > in

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Takashi Iwai
At Mon, 29 Apr 2013 08:02:19 -0700, Jesse Barnes wrote: > > On Sat, 27 Apr 2013 13:35:29 +0200 > Daniel Vetter wrote: > > > On Sat, Apr 27, 2013 at 09:20:39AM +, Wang, Xingchao wrote: > > > Let me throw a basic proposal on Audio driver side, please give your > > > comments freely. > > > >

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-02 Thread Wang, Xingchao
Hi Jesse, > -Original Message- > From: Barnes, Jesse > Sent: Monday, April 29, 2013 11:02 PM > To: Daniel Vetter > Cc: Wang, Xingchao; Takashi Iwai; Li, Jocelyn; Daniel Vetter; Zanoni, Paulo R; > ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, Liam R; > intel-gfx@lists.freedesktop.

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-29 Thread Jesse Barnes
On Sat, 27 Apr 2013 13:35:29 +0200 Daniel Vetter wrote: > On Sat, Apr 27, 2013 at 09:20:39AM +, Wang, Xingchao wrote: > > Let me throw a basic proposal on Audio driver side, please give your > > comments freely. > > > > it contains the power well control usage points: > > #1: audio request

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Daniel Vetter
On Sat, Apr 27, 2013 at 09:20:39AM +, Wang, Xingchao wrote: > Let me throw a basic proposal on Audio driver side, please give your > comments freely. > > it contains the power well control usage points: > #1: audio request power well at boot up. > I915 may shut down power well after bootup i

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Wang, Xingchao
Hi Daniel/Takashi, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Saturday, April 27, 2013 1:18 AM > To: Takashi Iwai > Cc: Daniel Vetter; Li, Jocelyn; Daniel Vetter; Wang, Xingchao; Zanoni, Paulo > R; > ville.syrj...@linux.in

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Wang, Xingchao
Hi Takashi, > -Original Message- > From: Takashi Iwai [mailto:ti...@suse.de] > Sent: Friday, April 26, 2013 11:13 PM > To: Daniel Vetter > Cc: Li, Jocelyn; Daniel Vetter; Wang, Xingchao; Zanoni, Paulo R; > ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, Liam R; > intel-gfx@lists.f

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-27 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Friday, April 26, 2013 10:57 PM > To: Li, Jocelyn > Cc: Daniel Vetter; Wang, Xingchao; Zanoni, Paulo R; > ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, Liam R;

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2013 at 05:45:15PM +0200, Takashi Iwai wrote: > At Fri, 26 Apr 2013 17:42:07 +0200, > Daniel Vetter wrote: > > > > On Fri, Apr 26, 2013 at 05:12:34PM +0200, Takashi Iwai wrote: > > > At Fri, 26 Apr 2013 16:57:08 +0200, > > > Daniel Vetter wrote: > > > > > > > > On Fri, Apr 26, 201

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Takashi Iwai
At Fri, 26 Apr 2013 17:42:07 +0200, Daniel Vetter wrote: > > On Fri, Apr 26, 2013 at 05:12:34PM +0200, Takashi Iwai wrote: > > At Fri, 26 Apr 2013 16:57:08 +0200, > > Daniel Vetter wrote: > > > > > > On Fri, Apr 26, 2013 at 07:53:41AM +, Li, Jocelyn wrote: > > > > -Original Message- >

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2013 at 05:12:34PM +0200, Takashi Iwai wrote: > At Fri, 26 Apr 2013 16:57:08 +0200, > Daniel Vetter wrote: > > > > On Fri, Apr 26, 2013 at 07:53:41AM +, Li, Jocelyn wrote: > > > -Original Message- > > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > > > Sent: Fr

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Takashi Iwai
At Fri, 26 Apr 2013 16:57:08 +0200, Daniel Vetter wrote: > > On Fri, Apr 26, 2013 at 07:53:41AM +, Li, Jocelyn wrote: > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > > Sent: Friday, April 26, 2013 3:25 PM > > To: Li, Jocelyn > > Cc: Wang, Xingchao; Zan

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2013 at 07:53:41AM +, Li, Jocelyn wrote: > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Friday, April 26, 2013 3:25 PM > To: Li, Jocelyn > Cc: Wang, Xingchao; Zanoni, Paulo R; ville.syrj...@linux.intel.com; Lin, > Mengdong; Girdwood,

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Li, Jocelyn
Hi Daniel, Please see my comments below. Regards, Jocelyn -Original Message- From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] Sent: Friday, April 26, 2013 3:25 PM To: Li, Jocelyn Cc: Wang, Xingchao; Zanoni, Paulo R; ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, Liam R; int

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2013 at 8:58 AM, Li, Jocelyn wrote: > Hi Guys, > > I apologize that I may have misunderstood on the agreement we have made on > power well work. I assumed that audio team is expected to create private gfx > driver API to control the power well between gfx and audio for internal

[Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-25 Thread Li, Jocelyn
Hi Guys, I apologize that I may have misunderstood on the agreement we have made on power well work. I assumed that audio team is expected to create private gfx driver API to control the power well between gfx and audio for internal releases. That's why I asked Xingchao work on that. So the co

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-25 Thread Wang, Xingchao
Hi Daniel, > -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Thursday, April 25, 2013 3:52 PM > To: Wang, Xingchao > Cc: Zanoni, Paulo R; ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, > Liam R; Li, Jocelyn; intel-gfx@lists.freedesktop.org; > alsa-

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-25 Thread Daniel Vetter
On Thu, Apr 25, 2013 at 4:36 AM, Wang, Xingchao wrote: > Hi Daniel/Paulo, > > Any comments on this? > Add Jesse and Rafael in loop. Well I've figured we want to get the power well integration working before we waste time reviewing an interface which might or might not quite work. But if you want,

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-24 Thread Wang, Xingchao
Hi Daniel/Paulo, Any comments on this? Add Jesse and Rafael in loop. thanks --xingchao > -Original Message- > From: Wang, Xingchao > Sent: Wednesday, April 24, 2013 3:29 PM > To: daniel.vet...@ffwll.ch; Zanoni, Paulo R; 'Takashi Iwai' > Cc: ville.syrj...@linux.intel.com; Lin, Mengdong;

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-24 Thread Wang, Xingchao
Hi Guys, Sorry I should Add Takashi and alsa maillist in loop. I tested this patch against Daniel's "drm-intel-next-queued" Branch, on Haswell Mobile C3 stepping machines. Test steps: 1. only connect one monitor through HDMI cable 2. echo 1 > /sys/module/i915/parameters/disable_power_well ==> I

[Intel-gfx] [PATCH] drm/i915: Add private api for power well usage

2013-04-24 Thread Wang Xingchao
Display audio depends on power well in graphic side, it should request power well before use it and release power well after use. I915 will not shutdown power well if it detects audio is using. This patch protects display audio crash for Intel Haswell mobile C3 stepping board. Signed-off-by: Wang