On Wed, Jan 29, 2014 at 3:56 PM, Ville Syrjälä
wrote:
> I think once we get to working on D0i2, we'll need to move the PSR
> wakeup to happen from a workqueue since it essentially requires a
> full modeset. Even now in your code it's somewhat questionable
> since you're doing stuff like aux transf
On Tue, Feb 04, 2014 at 11:03:25AM -0200, Rodrigo Vivi wrote:
> >> > In the case of a moving cursor that means indefinitely.
> >> That's true... So I think we really need a work queue delaying the enable.
> >> Or do you have any better idea?
> >
> > Yeah, sounds like we need a delayed work-queue to
>> > In the case of a moving cursor that means indefinitely.
>> That's true... So I think we really need a work queue delaying the enable.
>> Or do you have any better idea?
>
> Yeah, sounds like we need a delayed work-queue to re-enable psr, also for
> gtt mmap writes. See Chris' latest crazy exam
On Thu, Jan 30, 2014 at 03:01:08PM -0200, Rodrigo Vivi wrote:
> On Thu, Jan 30, 2014 at 11:02 AM, Chris Wilson
> wrote:
> > On Wed, Jan 29, 2014 at 01:50:06PM -0200, Rodrigo Vivi wrote:
> >> @@ -7501,6 +7501,9 @@ static void intel_crtc_update_cursor(struct drm_crtc
> >> *crtc,
> >> u32 bas
On Sat, Feb 01, 2014 at 11:34:02AM +, Chris Wilson wrote:
> On Wed, Jan 29, 2014 at 08:21:41PM +0100, Daniel Vetter wrote:
> > On Wed, Jan 29, 2014 at 12:55:35PM -0200, Rodrigo Vivi wrote:
> > > This patch adds PSR Support to Baytrail.
> > >
> > > Baytrail cannot easily detect screen updates a
On Wed, Jan 29, 2014 at 08:21:41PM +0100, Daniel Vetter wrote:
> On Wed, Jan 29, 2014 at 12:55:35PM -0200, Rodrigo Vivi wrote:
> > This patch adds PSR Support to Baytrail.
> >
> > Baytrail cannot easily detect screen updates and force PSR exit.
> > So we inactivate it on {busy_ioctl, sw_finish and
On Thu, Jan 30, 2014 at 11:02 AM, Chris Wilson wrote:
> On Wed, Jan 29, 2014 at 01:50:06PM -0200, Rodrigo Vivi wrote:
>> @@ -7501,6 +7501,9 @@ static void intel_crtc_update_cursor(struct drm_crtc
>> *crtc,
>> u32 base = 0, pos = 0;
>> bool visible;
>>
>> + if (IS_VALLEYVIEW(dev))
On Wed, Jan 29, 2014 at 01:50:06PM -0200, Rodrigo Vivi wrote:
> @@ -7501,6 +7501,9 @@ static void intel_crtc_update_cursor(struct drm_crtc
> *crtc,
> u32 base = 0, pos = 0;
> bool visible;
>
> + if (IS_VALLEYVIEW(dev))
> + intel_edp_psr_inactivate(dev);
> +
Inactivat
On Wed, Jan 29, 2014 at 12:55:35PM -0200, Rodrigo Vivi wrote:
> This patch adds PSR Support to Baytrail.
>
> Baytrail cannot easily detect screen updates and force PSR exit.
> So we inactivate it on {busy_ioctl, sw_finish and mark_busy}
> and update to enable it back on next display mark_idle.
>
On Wed, Jan 29, 2014 at 02:26:03PM +, Chris Wilson wrote:
> On Wed, Jan 29, 2014 at 12:23:15PM -0200, Rodrigo Vivi wrote:
> > ok, got it.
> >
> > So, the correct here is to remove inactivate from set_domain and add
> > gem_bo_busy call on MMAP_GTT testcase?
>
> That would match what we should
On Wed, Jan 29, 2014 at 03:48:21PM -0200, Rodrigo Vivi wrote:
> On Wed, Jan 29, 2014 at 2:38 PM, Ville Syrjälä
> wrote:
> > On Wed, Jan 29, 2014 at 01:47:00PM -0200, Rodrigo Vivi wrote:
> >> On Wed, Jan 29, 2014 at 12:56 PM, Ville Syrjälä
> >> wrote:
> >> > On Wed, Jan 29, 2014 at 10:47:54AM -020
On Wed, Jan 29, 2014 at 2:38 PM, Ville Syrjälä
wrote:
> On Wed, Jan 29, 2014 at 01:47:00PM -0200, Rodrigo Vivi wrote:
>> On Wed, Jan 29, 2014 at 12:56 PM, Ville Syrjälä
>> wrote:
>> > On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
>> >> This patch adds PSR Support to Baytrail.
>> >
On Wed, Jan 29, 2014 at 01:47:00PM -0200, Rodrigo Vivi wrote:
> On Wed, Jan 29, 2014 at 12:56 PM, Ville Syrjälä
> wrote:
> > On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
> >> This patch adds PSR Support to Baytrail.
> >>
> >> Baytrail cannot easily detect screen updates and force
This patch adds PSR Support to Baytrail.
Baytrail cannot easily detect screen updates and force PSR exit.
So we inactivate it on {busy_ioctl, sw_finish and mark_busy}
and update to enable it back on next display mark_idle.
v2: Also inactivate PSR on cursor update.
v3: Inactivate PSR on mark_busy,
On Wed, Jan 29, 2014 at 12:56 PM, Ville Syrjälä
wrote:
> On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
>> This patch adds PSR Support to Baytrail.
>>
>> Baytrail cannot easily detect screen updates and force PSR exit.
>> So we inactivate it on {busy_ioctl, set_domain, sw_finish and
On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
> This patch adds PSR Support to Baytrail.
>
> Baytrail cannot easily detect screen updates and force PSR exit.
> So we inactivate it on {busy_ioctl, set_domain, sw_finish and mark_busy
> and update to enable it back on next display mar
This patch adds PSR Support to Baytrail.
Baytrail cannot easily detect screen updates and force PSR exit.
So we inactivate it on {busy_ioctl, sw_finish and mark_busy}
and update to enable it back on next display mark_idle.
v2: Also inactivate PSR on cursor update.
v3: Inactivate PSR on mark_busy,
On Wed, Jan 29, 2014 at 12:23:15PM -0200, Rodrigo Vivi wrote:
> ok, got it.
>
> So, the correct here is to remove inactivate from set_domain and add
> gem_bo_busy call on MMAP_GTT testcase?
That would match what we should do today. It's just whether we take the
opportunity to define a consistent
ok, got it.
So, the correct here is to remove inactivate from set_domain and add
gem_bo_busy call on MMAP_GTT testcase?
On Wed, Jan 29, 2014 at 12:02 PM, Chris Wilson wrote:
> On Wed, Jan 29, 2014 at 11:54:00AM -0200, Rodrigo Vivi wrote:
>> On Wed, Jan 29, 2014 at 11:27 AM, Chris Wilson
>> wro
On Wed, Jan 29, 2014 at 11:54:00AM -0200, Rodrigo Vivi wrote:
> On Wed, Jan 29, 2014 at 11:27 AM, Chris Wilson
> wrote:
> > On Wed, Jan 29, 2014 at 11:24:44AM -0200, Rodrigo Vivi wrote:
> >> On Wed, Jan 29, 2014 at 11:12 AM, Chris Wilson
> >> wrote:
> >> > On Wed, Jan 29, 2014 at 10:47:54AM -02
On Wed, Jan 29, 2014 at 11:27 AM, Chris Wilson wrote:
> On Wed, Jan 29, 2014 at 11:24:44AM -0200, Rodrigo Vivi wrote:
>> On Wed, Jan 29, 2014 at 11:12 AM, Chris Wilson
>> wrote:
>> > On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
>> >> This patch adds PSR Support to Baytrail.
>> >
On Wed, Jan 29, 2014 at 11:24:44AM -0200, Rodrigo Vivi wrote:
> On Wed, Jan 29, 2014 at 11:12 AM, Chris Wilson
> wrote:
> > On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
> >> This patch adds PSR Support to Baytrail.
> >>
> >> Baytrail cannot easily detect screen updates and force
On Wed, Jan 29, 2014 at 11:12 AM, Chris Wilson wrote:
> On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
>> This patch adds PSR Support to Baytrail.
>>
>> Baytrail cannot easily detect screen updates and force PSR exit.
>> So we inactivate it on {busy_ioctl, set_domain, sw_finish and
On Wed, Jan 29, 2014 at 10:47:54AM -0200, Rodrigo Vivi wrote:
> This patch adds PSR Support to Baytrail.
>
> Baytrail cannot easily detect screen updates and force PSR exit.
> So we inactivate it on {busy_ioctl, set_domain, sw_finish and mark_busy
> and update to enable it back on next display mar
This patch adds PSR Support to Baytrail.
Baytrail cannot easily detect screen updates and force PSR exit.
So we inactivate it on {busy_ioctl, set_domain, sw_finish and mark_busy
and update to enable it back on next display mark_idle.
v2: Also inactivate PSR on cursor update.
v3: Inactivate PSR on
On Fri, Jan 24, 2014 at 02:05:57PM -0200, Rodrigo Vivi wrote:
> On Fri, Jan 24, 2014 at 12:53 PM, Ville Syrjälä
> wrote:
> > On Thu, Jan 23, 2014 at 05:19:53PM -0200, Rodrigo Vivi wrote:
> >
> >> index 76126e0..f5501ab 100644
> >> --- a/drivers/gpu/drm/i915/i915_reg.h
> >> +++ b/drivers/gpu/drm/i
On Fri, Jan 24, 2014 at 12:53 PM, Ville Syrjälä
wrote:
> On Thu, Jan 23, 2014 at 05:19:53PM -0200, Rodrigo Vivi wrote:
>
>> index 76126e0..f5501ab 100644
>> --- a/drivers/gpu/drm/i915/i915_reg.h
>> +++ b/drivers/gpu/drm/i915/i915_reg.h
>> @@ -1969,6 +1969,40 @@
>> #define BCLRPAT(pipe) _PIPE(pip
On Thu, Jan 23, 2014 at 05:19:53PM -0200, Rodrigo Vivi wrote:
> index 76126e0..f5501ab 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -1969,6 +1969,40 @@
> #define BCLRPAT(pipe) _PIPE(pipe, _BCLRPAT_A, _BCLRPAT_B)
> #define VSYNCSHIFT(trans) _TRANSCOD
This patch adds PSR Support to Baytrail.
Baytrail cannot easily detect screen updates and force PSR exit.
So we inactivate it on {busy_ioctl, set_domain, sw_finish and mark_busy
and update to enable it back on next display mark_idle.
v2: Also inactivate PSR on cursor update.
v3: Inactivate PSR on
On Wed, Dec 18, 2013 at 08:27:32AM -0200, Rodrigo Vivi wrote:
> On Wed, Dec 18, 2013 at 8:03 AM, Chris Wilson
> wrote:
> > On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote:
> >> This patch adds PSR Support to Baytrail.
> >>
> >> Baytrail cannot easily detect screen updates and force P
On Wed, Dec 18, 2013 at 8:27 AM, Rodrigo Vivi wrote:
> On Wed, Dec 18, 2013 at 8:03 AM, Chris Wilson
> wrote:
>> On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote:
>>> This patch adds PSR Support to Baytrail.
>>>
>>> Baytrail cannot easily detect screen updates and force PSR exit.
>>>
On Wed, Dec 18, 2013 at 8:03 AM, Chris Wilson wrote:
> On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote:
>> This patch adds PSR Support to Baytrail.
>>
>> Baytrail cannot easily detect screen updates and force PSR exit.
>> So we inactivate it on busy_ioctl and update to get it back
>>
On Tue, Dec 17, 2013 at 06:31:03PM -0200, Rodrigo Vivi wrote:
> This patch adds PSR Support to Baytrail.
>
> Baytrail cannot easily detect screen updates and force PSR exit.
> So we inactivate it on busy_ioctl and update to get it back
> on next display mark_idle.
That wasn't the plan, and certai
This patch adds PSR Support to Baytrail.
Baytrail cannot easily detect screen updates and force PSR exit.
So we inactivate it on busy_ioctl and update to get it back
on next display mark_idle.
v2: Also inactivate PSR on cursor update.
Signed-off-by: Rodrigo Vivi
---
drivers/gpu/drm/i915/i915_d
34 matches
Mail list logo
