Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-16 Thread Yang, Libin
essage- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Friday, July 15, 2016 4:45 PM > To: Yang, Libin > Cc: Mika Kuoppala ; intel- > g...@lists.freedesktop.org; Takashi Iwai > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD- > Aud

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-15 Thread Chris Wilson
ktop.org; Takashi Iwai ; Yang, Libin > > > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD- > > Audio registers > > > > On Wed, Jul 13, 2016 at 05:01:02PM +0300, Marius Vlad wrote: > > > Did try when you submitted the patch

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-14 Thread Yang, Libin
Hi Wilson, > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, July 14, 2016 10:34 PM > To: Mika Kuoppala ; intel- > g...@lists.freedesktop.org; Takashi Iwai ; Yang, Libin > > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Acq

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-14 Thread Chris Wilson
On Wed, Jul 13, 2016 at 05:01:02PM +0300, Marius Vlad wrote: > Did try when you submitted the patch...but can't seem to replicate with > latest nightly on other SKLs, and currently do not have access on > the machine that caused it. So fwiw, Hans de Geode confirmed that only reverting 03b135cebc47

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-13 Thread Marius Vlad
Did try when you submitted the patch...but can't seem to replicate with latest nightly on other SKLs, and currently do not have access on the machine that caused it. On Tue, Jul 12, 2016 at 02:16:50PM +0100, Chris Wilson wrote: > On Tue, Jul 12, 2016 at 04:10:22PM +0300, Mika Kuoppala wrote: > > C

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-12 Thread Chris Wilson
On Tue, Jul 12, 2016 at 04:10:22PM +0300, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Haswell/Broadwell, the HD-Audio block is inside the HDMI/display > > power well and so the sna-hda audio codec acquires the display power > > well while it is operational. However, Skylake separates the

Re: [Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-12 Thread Mika Kuoppala
Chris Wilson writes: > On Haswell/Broadwell, the HD-Audio block is inside the HDMI/display > power well and so the sna-hda audio codec acquires the display power > well while it is operational. However, Skylake separates the powerwells > again, and so we must remember to acquire the rpm wakeref f

[Intel-gfx] [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers

2016-07-09 Thread Chris Wilson
On Haswell/Broadwell, the HD-Audio block is inside the HDMI/display power well and so the sna-hda audio codec acquires the display power well while it is operational. However, Skylake separates the powerwells again, and so we must remember to acquire the rpm wakeref for ourselves whilst tweaking th