Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2016-01-22 Thread Imre Deak
On Thu, 2016-01-21 at 13:52 +0200, Joonas Lahtinen wrote: > On to, 2016-01-14 at 18:50 +0200, Imre Deak wrote: > [...] > Below patch looks fine. Just that I'd use s/if_enabled/if_in_use/ to > match the PM API better. We're already doing too much of a good job > to > having many names for same thing

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2016-01-21 Thread Joonas Lahtinen
On to, 2016-01-14 at 18:50 +0200, Imre Deak wrote: > On la, 2015-12-19 at 09:58 +, Chris Wilson wrote: > > Once all the preparations are complete, we are ready to write the > > modesetting to the hardware. During this phase, we will be making > > lots > > of HW register access, so take a top le

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2016-01-14 Thread Imre Deak
On la, 2015-12-19 at 09:58 +, Chris Wilson wrote: > Once all the preparations are complete, we are ready to write the > modesetting to the hardware. During this phase, we will be making > lots > of HW register access, so take a top level wakeref to prevent an > unwarranted rpm suspend cycle mid

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-22 Thread Chris Wilson
On Mon, Dec 21, 2015 at 07:21:33PM +0100, Daniel Vetter wrote: > On Mon, Dec 21, 2015 at 04:37:41PM +, Chris Wilson wrote: > > On Mon, Dec 21, 2015 at 05:28:16PM +0100, Daniel Vetter wrote: > > > On Mon, Dec 21, 2015 at 04:14:53PM +, Chris Wilson wrote: > > > > On Mon, Dec 21, 2015 at 05:02

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-21 Thread Daniel Vetter
On Mon, Dec 21, 2015 at 04:37:41PM +, Chris Wilson wrote: > On Mon, Dec 21, 2015 at 05:28:16PM +0100, Daniel Vetter wrote: > > On Mon, Dec 21, 2015 at 04:14:53PM +, Chris Wilson wrote: > > > On Mon, Dec 21, 2015 at 05:02:08PM +0100, Daniel Vetter wrote: > > > > On Sat, Dec 19, 2015 at 09:58

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-21 Thread Chris Wilson
On Mon, Dec 21, 2015 at 05:28:16PM +0100, Daniel Vetter wrote: > On Mon, Dec 21, 2015 at 04:14:53PM +, Chris Wilson wrote: > > On Mon, Dec 21, 2015 at 05:02:08PM +0100, Daniel Vetter wrote: > > > On Sat, Dec 19, 2015 at 09:58:43AM +, Chris Wilson wrote: > > > > Once all the preparations are

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-21 Thread Daniel Vetter
On Mon, Dec 21, 2015 at 04:14:53PM +, Chris Wilson wrote: > On Mon, Dec 21, 2015 at 05:02:08PM +0100, Daniel Vetter wrote: > > On Sat, Dec 19, 2015 at 09:58:43AM +, Chris Wilson wrote: > > > Once all the preparations are complete, we are ready to write the > > > modesetting to the hardware.

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-21 Thread Chris Wilson
On Mon, Dec 21, 2015 at 05:02:08PM +0100, Daniel Vetter wrote: > On Sat, Dec 19, 2015 at 09:58:43AM +, Chris Wilson wrote: > > Once all the preparations are complete, we are ready to write the > > modesetting to the hardware. During this phase, we will be making lots > > of HW register access,

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-21 Thread Daniel Vetter
On Sat, Dec 19, 2015 at 09:58:43AM +, Chris Wilson wrote: > Once all the preparations are complete, we are ready to write the > modesetting to the hardware. During this phase, we will be making lots > of HW register access, so take a top level wakeref to prevent an > unwarranted rpm suspend cyc

[Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2015-12-19 Thread Chris Wilson
Once all the preparations are complete, we are ready to write the modesetting to the hardware. During this phase, we will be making lots of HW register access, so take a top level wakeref to prevent an unwarranted rpm suspend cycle mid-commit. Lower level functions should be waking the individual p