Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling v3

2013-09-30 Thread Ville Syrjälä
On Mon, Sep 30, 2013 at 03:20:44PM -0700, Jesse Barnes wrote: > On Tue, 1 Oct 2013 00:19:55 +0300 > Ville Syrjälä wrote: > > > On Sat, Sep 28, 2013 at 08:05:14AM -0700, Jesse Barnes wrote: > > > On Sat, 28 Sep 2013 11:54:21 +0200 > > > Daniel Vetter wrote: > > > > > > > On Fri, Sep 27, 2013 at

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling v3

2013-09-30 Thread Jesse Barnes
On Tue, 1 Oct 2013 00:19:55 +0300 Ville Syrjälä wrote: > On Sat, Sep 28, 2013 at 08:05:14AM -0700, Jesse Barnes wrote: > > On Sat, 28 Sep 2013 11:54:21 +0200 > > Daniel Vetter wrote: > > > > > On Fri, Sep 27, 2013 at 04:02:29PM -0700, Jesse Barnes wrote: > > > > The global integrated clock sour

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling v3

2013-09-30 Thread Ville Syrjälä
On Sat, Sep 28, 2013 at 08:05:14AM -0700, Jesse Barnes wrote: > On Sat, 28 Sep 2013 11:54:21 +0200 > Daniel Vetter wrote: > > > On Fri, Sep 27, 2013 at 04:02:29PM -0700, Jesse Barnes wrote: > > > The global integrated clock source bit resides in DPLL B on VLV, but we > > > were treating it as a p

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling v3

2013-09-28 Thread Jesse Barnes
On Sat, 28 Sep 2013 11:54:21 +0200 Daniel Vetter wrote: > On Fri, Sep 27, 2013 at 04:02:29PM -0700, Jesse Barnes wrote: > > The global integrated clock source bit resides in DPLL B on VLV, but we > > were treating it as a per-pipe resource. It needs to be set whenever > > any PLL is active, so p

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling v3

2013-09-28 Thread Daniel Vetter
On Fri, Sep 27, 2013 at 04:02:29PM -0700, Jesse Barnes wrote: > The global integrated clock source bit resides in DPLL B on VLV, but we > were treating it as a per-pipe resource. It needs to be set whenever > any PLL is active, so pull setting the bit out of vlv_update_pll and > into vlv_enable_pl

[Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling v3

2013-09-27 Thread Jesse Barnes
The global integrated clock source bit resides in DPLL B on VLV, but we were treating it as a per-pipe resource. It needs to be set whenever any PLL is active, so pull setting the bit out of vlv_update_pll and into vlv_enable_pll. Also add a vlv_disable_pll to prevent disabling it when pipe B shu

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling

2013-09-27 Thread Jesse Barnes
On Fri, 27 Sep 2013 23:09:26 +0300 Ville Syrjälä wrote: > On Fri, Sep 27, 2013 at 12:22:11PM -0700, Jesse Barnes wrote: > > The global integrated clock source bit resides in DPLL B on VLV, but we > > were treating it as a per-pipe resource. It needs to be set whenever > > any PLL is active, > >

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling

2013-09-27 Thread Ville Syrjälä
On Fri, Sep 27, 2013 at 12:22:11PM -0700, Jesse Barnes wrote: > The global integrated clock source bit resides in DPLL B on VLV, but we > were treating it as a per-pipe resource. It needs to be set whenever > any PLL is active, Actually AFAIU the cri clock has to be running even if we just attemp

Re: [Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling

2013-09-27 Thread Daniel Vetter
On Fri, Sep 27, 2013 at 12:22:11PM -0700, Jesse Barnes wrote: > The global integrated clock source bit resides in DPLL B on VLV, but we > were treating it as a per-pipe resource. It needs to be set whenever > any PLL is active, so pull setting the bit out of vlv_update_pll and > into vlv_enable_pl

[Intel-gfx] [PATCH] drm/i915/vlv: untangle integrated clock source handling

2013-09-27 Thread Jesse Barnes
The global integrated clock source bit resides in DPLL B on VLV, but we were treating it as a per-pipe resource. It needs to be set whenever any PLL is active, so pull setting the bit out of vlv_update_pll and into vlv_enable_pll. Also add a vlv_disable_pll to prevent disabling it when pipe B shu