Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-25 Thread Ville Syrjälä
On Mon, Jul 25, 2016 at 02:46:01PM +0200, Maarten Lankhorst wrote: > Op 25-07-16 om 13:51 schreef Ville Syrjälä: > > On Mon, Jul 25, 2016 at 01:32:45PM +0200, Maarten Lankhorst wrote: > >> Hey, > >> > >> Op 19-07-16 om 18:21 schreef Ville Syrjälä: > >>> On Tue, Jul 19, 2016 at 04:50:49PM +0100, Chr

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-25 Thread Maarten Lankhorst
Op 25-07-16 om 13:51 schreef Ville Syrjälä: > On Mon, Jul 25, 2016 at 01:32:45PM +0200, Maarten Lankhorst wrote: >> Hey, >> >> Op 19-07-16 om 18:21 schreef Ville Syrjälä: >>> On Tue, Jul 19, 2016 at 04:50:49PM +0100, Chris Wilson wrote: On Tue, Jul 19, 2016 at 06:25:42PM +0300, Ville Syrjälä w

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-25 Thread Ville Syrjälä
On Mon, Jul 25, 2016 at 01:32:45PM +0200, Maarten Lankhorst wrote: > Hey, > > Op 19-07-16 om 18:21 schreef Ville Syrjälä: > > On Tue, Jul 19, 2016 at 04:50:49PM +0100, Chris Wilson wrote: > >> On Tue, Jul 19, 2016 at 06:25:42PM +0300, Ville Syrjälä wrote: > >>> On Tue, Jul 19, 2016 at 05:14:23PM +

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-25 Thread Maarten Lankhorst
Hey, Op 19-07-16 om 18:21 schreef Ville Syrjälä: > On Tue, Jul 19, 2016 at 04:50:49PM +0100, Chris Wilson wrote: >> On Tue, Jul 19, 2016 at 06:25:42PM +0300, Ville Syrjälä wrote: >>> On Tue, Jul 19, 2016 at 05:14:23PM +0200, Maarten Lankhorst wrote: num_levels should be level+1, not level, el

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-20 Thread Maarten Lankhorst
Op 19-07-16 om 17:14 schreef Maarten Lankhorst: > num_levels should be level+1, not level, else num_levels - 1 becomes > negative. This resulted in bogus watermarks being written to the first > 255 levels like below: > > [drm] Setting FIFO watermarks - C: plane=0, cursor=0, sprite0=0, sprite1=0, >

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-19 Thread Ville Syrjälä
On Tue, Jul 19, 2016 at 04:50:49PM +0100, Chris Wilson wrote: > On Tue, Jul 19, 2016 at 06:25:42PM +0300, Ville Syrjälä wrote: > > On Tue, Jul 19, 2016 at 05:14:23PM +0200, Maarten Lankhorst wrote: > > > num_levels should be level+1, not level, else num_levels - 1 becomes > > > negative. This resul

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-19 Thread Chris Wilson
On Tue, Jul 19, 2016 at 06:25:42PM +0300, Ville Syrjälä wrote: > On Tue, Jul 19, 2016 at 05:14:23PM +0200, Maarten Lankhorst wrote: > > num_levels should be level+1, not level, else num_levels - 1 becomes > > negative. This resulted in bogus watermarks being written to the first > > 255 levels like

Re: [Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-19 Thread Ville Syrjälä
On Tue, Jul 19, 2016 at 05:14:23PM +0200, Maarten Lankhorst wrote: > num_levels should be level+1, not level, else num_levels - 1 becomes > negative. This resulted in bogus watermarks being written to the first > 255 levels like below: > > [drm] Setting FIFO watermarks - C: plane=0, cursor=0, spri

[Intel-gfx] [PATCH] drm/i915/vlv: Fix off-by-1 error in calculating num_levels.

2016-07-19 Thread Maarten Lankhorst
num_levels should be level+1, not level, else num_levels - 1 becomes negative. This resulted in bogus watermarks being written to the first 255 levels like below: [drm] Setting FIFO watermarks - C: plane=0, cursor=0, sprite0=0, sprite1=0, SR: plane=0, cursor=0 level=255 cxsr=0 [drm:chv_set_memory