Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-09 Thread Daniel Vetter
On Fri, May 06, 2016 at 02:16:29PM +0300, Ville Syrjälä wrote: > On Thu, May 05, 2016 at 07:17:02AM +, Antoine, Peter wrote: > > It's a little overkill? > > > > They just need to know if the cache tables have changed and to be able to > > sync their indexes to the KMD. > > We already shot ou

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-06 Thread Peter Antoine
h...@chris-wilson.co.uk] Sent: Wednesday, May 4, 2016 2:47 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state On Wed, May 04, 2016 at 02:32:53PM +0100, Peter Antoine wrote: Will wait for more comments, then w

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-06 Thread Ville Syrjälä
e way and come up with a way for userspace to reconfigure the MOCS table at will? > Peter. > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Wednesday, May 4, 2016 5:56 PM > To: Antoine, Peter > Cc: Chris Wilson ; intel-gfx@lists.freed

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-06 Thread Antoine, Peter
Anymore feedback on this? -Original Message- From: Antoine, Peter Sent: Thursday, May 5, 2016 8:17 AM To: Ville Syrjälä Cc: Chris Wilson ; intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: RE: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state It's a little ove

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-05 Thread Antoine, Peter
.intel.com] Sent: Wednesday, May 4, 2016 5:56 PM To: Antoine, Peter Cc: Chris Wilson ; intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state On Wed, May 04, 2016 at 03:51:21PM +0100, Peter Antoine wrote: > > Sorry Ville,

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Ville Syrjälä
> mocs/control_state > >> mocs/l3cc_state > >> > >> for the different tables? > >> > >> Peter. > >> > >> -----Original Message- > >> From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > >> Sent: Wednesday, May 4, 2016 2:

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Chris Wilson
On Wed, May 04, 2016 at 05:38:41PM +0300, Ville Syrjälä wrote: > On Wed, May 04, 2016 at 02:23:35PM +, Antoine, Peter wrote: > > No, It's not debug. > > It's for syncing and aligning (and validating) the open-source userspace > > with the kernel cache policy. > > Why doesn't userspace just us

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Peter Antoine
mocs/l3cc_state for the different tables? Peter. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Wednesday, May 4, 2016 2:47 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding m

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Antoine, Peter
r the different tables? Peter. -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Wednesday, May 4, 2016 2:47 PM To: Antoine, Peter Cc: intel-gfx@lists.freedesktop.org; Widawsky, Benjamin Subject: Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Ville Syrjälä
for the different tables? > > Peter. > > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Wednesday, May 4, 2016 2:47 PM > To: Antoine, Peter > Cc: intel-gfx@lists.freedesktop.org; Widawsky, Benjamin > > Subject: Re: [Intel-gfx]

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Chris Wilson
On Wed, May 04, 2016 at 02:32:53PM +0100, Peter Antoine wrote: > Will wait for more comments, then will respin with a different > commit message. Is the rest of the patch ok? No, you've put debug information into sysfs. (Also sysfs is one value per file.) sysfs does not match your goal of validati

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Peter Antoine
Will wait for more comments, then will respin with a different commit message. Is the rest of the patch ok? Peter. On Wed, 4 May 2016, Chris Wilson wrote: On Wed, May 04, 2016 at 02:16:23PM +0100, Peter Antoine wrote: The following patch adds the current MOCS state to the sysfs file system.

Re: [Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Chris Wilson
On Wed, May 04, 2016 at 02:16:23PM +0100, Peter Antoine wrote: > The following patch adds the current MOCS state to the sysfs file > system. This patch has been added so that userspace can validate the > MOCS settings that have been programmed. These only correspond to the state the kernel may pro

[Intel-gfx] [PATCH] drm/i915/sysfs: Adding mocs_state

2016-05-04 Thread Peter Antoine
The following patch adds the current MOCS state to the sysfs file system. This patch has been added so that userspace can validate the MOCS settings that have been programmed. Tracked-On: https://jira01.devtools.intel.com/browse/VIZ-7767 Signed-off-by: Peter Antoine --- drivers/gpu/drm/i915/i915