Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-18 Thread Mika Kuoppala
Chris Wilson writes: > The old wait_on_atomic_t used a custom callback to perform the > schedule(), which used my return semantics of reporting an error code on > timeout. wait_var_event_timeout() uses the schedule() return semantics > of reporting the remaining jiffies (1 if it timed out with 0

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-18 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-04-18 12:14:15) > Quoting Joonas Lahtinen (2018-04-18 10:10:17) > > Quoting Chris Wilson (2018-04-17 20:06:38) > > > The old wait_on_atomic_t used a custom callback to perform the > > > schedule(), which used my return semantics of reporting an error code on > > > timeout

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-18 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-04-18 10:10:17) > Quoting Chris Wilson (2018-04-17 20:06:38) > > The old wait_on_atomic_t used a custom callback to perform the > > schedule(), which used my return semantics of reporting an error code on > > timeout. wait_var_event_timeout() uses the schedule() return

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-18 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-04-17 20:06:38) > The old wait_on_atomic_t used a custom callback to perform the > schedule(), which used my return semantics of reporting an error code on > timeout. wait_var_event_timeout() uses the schedule() return semantics > of reporting the remaining jiffies (1 if

[Intel-gfx] [PATCH] drm/i915/selftests: Fix error checking for wait_var_timeout

2018-04-17 Thread Chris Wilson
The old wait_on_atomic_t used a custom callback to perform the schedule(), which used my return semantics of reporting an error code on timeout. wait_var_event_timeout() uses the schedule() return semantics of reporting the remaining jiffies (1 if it timed out with 0 jiffies remaining!) and 0 on fa