Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-24 Thread Jani Nikula
On Tue, 22 May 2018, Jani Nikula wrote: > On Tue, 22 May 2018, vathsala nagaraju wrote: >> From: Vathsala Nagaraju >> >> For psr block #9, the vbt description has moved to options [0-3] for >> TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt >> structure. Since spec does not

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-23 Thread Jani Nikula
On Wed, 23 May 2018, "Nagaraju, Vathsala" wrote: > On 5/23/2018 3:33 PM, Jani Nikula wrote: >> Why did you send this again? Did you change something? I already >> reviewed the version from yesterday. > no code change, added only  rb tag by you and resent it. For future reference, you should *not*

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-23 Thread Nagaraju, Vathsala
On 5/23/2018 3:33 PM, Jani Nikula wrote: On Wed, 23 May 2018, vathsala nagaraju wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention fr

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-23 Thread Jani Nikula
On Wed, 23 May 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-22 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-22 Thread Jani Nikula
On Tue, 22 May 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-22 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-22 Thread Nagaraju, Vathsala
On 5/22/2018 1:35 PM, Jani Nikula wrote: On Tue, 22 May 2018, "Nagaraju, Vathsala" wrote: On 5/18/2018 3:01 PM, Jani Nikula wrote: On Fri, 18 May 2018, vathsala nagaraju wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-22 Thread Jani Nikula
On Tue, 22 May 2018, "Nagaraju, Vathsala" wrote: > On 5/18/2018 3:01 PM, Jani Nikula wrote: >> On Fri, 18 May 2018, vathsala nagaraju wrote: >>> From: Vathsala Nagaraju >>> >>> For psr block #9, the vbt description has moved to options [0-3] for >>> TP1,TP2,TP3 Wakeup time from decimal value wit

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-21 Thread Nagaraju, Vathsala
On 5/18/2018 3:01 PM, Jani Nikula wrote: On Fri, 18 May 2018, vathsala nagaraju wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention fr

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-18 Thread Jani Nikula
On Fri, 18 May 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-18 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-17 Thread Dhinakaran Pandiyan
On Thu, 2018-05-17 at 11:02 +0300, Jani Nikula wrote: > On Wed, 16 May 2018, Dhinakaran Pandiyan om> wrote: > > > > On Wed, 2018-05-16 at 11:08 +0300, Jani Nikula wrote: > > > > > > I think the patch is now the way it should be. We should not > > > change > > > our interpretation based on the va

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-17 Thread Jani Nikula
On Wed, 16 May 2018, Dhinakaran Pandiyan wrote: > On Wed, 2018-05-16 at 11:08 +0300, Jani Nikula wrote: >> I think the patch is now the way it should be. We should not change >> our interpretation based on the value. > > Is it correct to infer, from your response, that VBT values are not > always

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Dhinakaran Pandiyan
On Wed, 2018-05-16 at 09:14 +0530, vathsala nagaraju wrote: > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: > > > > On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: > > > > > > From: Vathsala Nagaraju > > > > > > For psr block #9, the vbt description has moved to opti

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Dhinakaran Pandiyan
On Wed, 2018-05-16 at 11:08 +0300, Jani Nikula wrote: > On Wed, 16 May 2018, vathsala nagaraju > wrote: > > > > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: > > > > > > On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: > > > > > > > > From: Vathsala Nagaraju > > > >

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Jani Nikula
On Wed, 16 May 2018, vathsala nagaraju wrote: > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: >> On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: >>> From: Vathsala Nagaraju >>> >>> For psr block #9, the vbt description has moved to options [0-3] for >>> TP1,TP2,TP3 Wak

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-16 Thread Jani Nikula
On Wed, 16 May 2018, vathsala nagaraju wrote: > On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: >> On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: >>> From: Vathsala Nagaraju >>> >>> For psr block #9, the vbt description has moved to options [0-3] for >>> TP1,TP2,TP3 Wak

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-15 Thread vathsala nagaraju
On Wednesday 16 May 2018 04:25 AM, Puthikorn Voravootivat wrote: On Sun, May 13, 2018 at 8:32 PM vathsala nagaraju < vathsala.nagar...@intel.com> wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value witho

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-15 Thread vathsala nagaraju
On Wednesday 16 May 2018 04:33 AM, Dhinakaran Pandiyan wrote: On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure.

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-15 Thread Puthikorn Voravootivat
On Sun, May 13, 2018 at 8:32 PM vathsala nagaraju < vathsala.nagar...@intel.com> wrote: > From: Vathsala Nagaraju > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mentio

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-15 Thread Dhinakaran Pandiyan
On Mon, 2018-05-14 at 09:02 +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not  mention from which VBT version th

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-13 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-04 Thread Puthikorn Voravootivat
FYI, Here is the the BDB version of the chip that need this change in Google Pixelbook. localhost ~ # uname -p Intel(R) Core(TM) i5-7Y57 CPU @ 1.20GHz localhost ~ # dmesg | grep VBT.signature [0.298850] VBT signature "$VBT SKYLAKE", BDB version 211 localhost ~ # uname -p Intel(R) Cor

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread Nagaraju, Vathsala
Rodrigo, The changes are already in place on kabylake 209+ onwards, So limiting this change to only kabylake and confirmed vbt version for now. RCR is already raised for GOP team to resolve. Once we get the other platform confirmation, we can add those platforms too. Here is

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread Rodrigo Vivi
On Thu, May 03, 2018 at 05:06:09PM +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT ver

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread Jani Nikula
On Thu, 03 May 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread Jani Nikula
On Wed, 02 May 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-02 Thread Jani Nikula
On Wed, 02 May 2018, Rodrigo Vivi wrote: > On Wed, May 02, 2018 at 02:43:29PM +0530, vathsala nagaraju wrote: >> From: Vathsala Nagaraju >> >> For psr block #9, the vbt description has moved to options [0-3] for >> TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt >> structure

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-02 Thread vathsala nagaraju
On Thursday 03 May 2018 02:45 AM, Rodrigo Vivi wrote: On Wed, May 02, 2018 at 02:43:29PM +0530, vathsala nagaraju wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure.

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-02 Thread Rodrigo Vivi
On Wed, May 02, 2018 at 02:43:29PM +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT ver

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-02 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-27 Thread Jani Nikula
On Fri, 20 Apr 2018, vathsala nagaraju wrote: > On Thursday 19 April 2018 07:05 PM, Jani Nikula wrote: >> On Thu, 19 Apr 2018, vathsala nagaraju wrote: >>> From: Vathsala Nagaraju >>> >>> For psr block #9, the vbt description has moved to options [0-3] for >>> TP1,TP2,TP3 Wakeup time from decima

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-19 Thread vathsala nagaraju
On Thursday 19 April 2018 07:05 PM, Jani Nikula wrote: On Thu, 19 Apr 2018, vathsala nagaraju wrote: From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-19 Thread Jani Nikula
On Thu, 19 Apr 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-19 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-12 Thread Jani Nikula
On Wed, 11 Apr 2018, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT version this > change wa

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-11 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-09 Thread Jani Nikula
On Fri, 06 Apr 2018, Rodrigo Vivi wrote: > On Fri, Apr 06, 2018 at 10:58:51PM +0530, vathsala nagaraju wrote: >> From: Vathsala Nagaraju >> >> For psr block #9, the vbt description has moved to options [0-3] for >> TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt >> structure

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-06 Thread Rodrigo Vivi
On Fri, Apr 06, 2018 at 10:58:51PM +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT ver

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-06 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we cannot depend on bdb->version