Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-30 Thread Rodrigo Vivi
Patch merged to dinq, thanks. I didn't put on fixes nor Cc'ed stable after chatting with Daniel about that. Since PSR is currently disabled on 4.11 there is no risk of this blowing anything nor changing the expected default behaviour. So dinq seemed to be the right place for this patch. Thanks, R

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-29 Thread Jani Nikula
On Fri, 26 May 2017, Rodrigo Vivi wrote: > I believe we need to cc:stable on this right?! > > Jani, is this ok to go ahead and merge after stable is cc'ed? Please add this, and it'll all happen automagically. Fixes: acf45d11050a ("drm/i915/psr: disable psr2 for resolution greater than 32X20") C

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-26 Thread Rodrigo Vivi
I believe we need to cc:stable on this right?! Jani, is this ok to go ahead and merge after stable is cc'ed? On Thu, May 25, 2017 at 9:43 AM, vathsala nagaraju wrote: > psr1 is also disabled for panel resolution greater than 32X20. > Added psr2 check to disable only for psr2 panels having resol

[Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-25 Thread vathsala nagaraju
psr1 is also disabled for panel resolution greater than 32X20. Added psr2 check to disable only for psr2 panels having resolution greater than 32X20. issue was introduced by commit-id : "acf45d11050abd751dcec986ab121cb2367dcbba" commit message: "PSR2 is restricted to work with panel resolutions u

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-24 Thread Jani Nikula
On Tue, 23 May 2017, "Vivi, Rodrigo" wrote: > A bit of history on the commit message pointing the commit that > introduced the issue is desired. s/desired/absolutely required/. BR, Jani. > > With that in place feel free to use: > Reviewed-by: Rodrigo Vivi > > On Tue, 2017-05-23 at 22:27 +0530

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-23 Thread Vivi, Rodrigo
A bit of history on the commit message pointing the commit that introduced the issue is desired. With that in place feel free to use: Reviewed-by: Rodrigo Vivi On Tue, 2017-05-23 at 22:27 +0530, vathsala nagaraju wrote: > psr1 is also disabled for panel resolution greater than 32X20. > Added p

[Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-23 Thread vathsala nagaraju
psr1 is also disabled for panel resolution greater than 32X20. Added psr2 check to disable only for psr2 panels having resolution greater than 32X20. Cc: Rodrigo Vivi Cc: Jim Bride Cc: Yaroslav Shabalin Signed-off-by: vathsala nagaraju --- drivers/gpu/drm/i915/intel_psr.c | 5 +++-- 1 file c

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-23 Thread Nagaraju, Vathsala
] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20 Hi! I'm not sure if this is suitable way to report bugs but seems that this change breaks PSR support on my laptop. I have Dell XPS 15 9550 with Skylake i7-6700HQ CPU, 4K screen resolution (3840x2160) and Arch Linux inst

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-23 Thread Yaroslav Shabalin
Hi! I'm not sure if this is suitable way to report bugs but seems that this change breaks PSR support on my laptop. I have Dell XPS 15 9550 with Skylake i7-6700HQ CPU, 4K screen resolution (3840x2160) and Arch Linux installed. Having i915.enable_psr=1 boot parameter on kernels <= 4.10 I get the fo

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-23 Thread Nagaraju, Vathsala
Hi Shablin, I will look In to it and provide the fix. Regards, Vathsala From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Yaroslav Shabalin Sent: Tuesday, May 23, 2017 2:45 PM To: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915/psr: disable

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-05-23 Thread Yaroslav Shabalin
Hi! I'm not sure if this is suitable way to report bugs but seems that this change ( https://github.com/torvalds/linux/commit/acf45d11050abd751dcec986ab121cb2367dcbba) breaks PSR support on my laptop. I have Dell XPS 15 9550 with Skylake i7-6700HQ CPU, 4K screen resolution (3840x2160) and Arch Lin

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-01-10 Thread Rodrigo Vivi
patch merged to dinq. thanks for the patch On Tue, Jan 10, 2017 at 12:48 PM Vivi, Rodrigo wrote: > Reviewed-by: Rodrigo Vivi > > On Tue, 2017-01-10 at 12:32 +0530, vathsala nagaraju wrote: > > PSR2 is restricted to work with panel resolutions upto 3200x2000, > > move the check to intel_psr_matc

Re: [Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-01-10 Thread Vivi, Rodrigo
Reviewed-by: Rodrigo Vivi On Tue, 2017-01-10 at 12:32 +0530, vathsala nagaraju wrote: > PSR2 is restricted to work with panel resolutions upto 3200x2000, > move the check to intel_psr_match_conditions and fully block psr. > > Cc: Rodrigo Vivi > Cc: Jim Bride > Suggested-by: Rodrigo Vivi > Sig

[Intel-gfx] [PATCH] drm/i915/psr: disable psr2 for resolution greater than 32X20

2017-01-09 Thread vathsala nagaraju
PSR2 is restricted to work with panel resolutions upto 3200x2000, move the check to intel_psr_match_conditions and fully block psr. Cc: Rodrigo Vivi Cc: Jim Bride Suggested-by: Rodrigo Vivi Signed-off-by: Vathsala Nagaraju --- drivers/gpu/drm/i915/intel_psr.c | 15 --- 1 file chan