Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-25 Thread Umesh Nerlige Ramappa
On Tue, Oct 24, 2023 at 02:20:33PM +0200, Andi Shyti wrote: Hi Umesh, On Fri, Oct 20, 2023 at 08:24:41AM -0700, Umesh Nerlige Ramappa wrote: When the driver unbinds, pmu is unregistered and i915->uabi_engines is set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine events, it issu

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-25 Thread Andi Shyti
Hi Umesh, On Fri, Oct 20, 2023 at 08:24:41AM -0700, Umesh Nerlige Ramappa wrote: > When the driver unbinds, pmu is unregistered and i915->uabi_engines is > set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine > events, it issues a warn_on because engine lookup fails. > > All perf h

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-24 Thread Andi Shyti
Hi Umesh, On Fri, Oct 20, 2023 at 08:24:41AM -0700, Umesh Nerlige Ramappa wrote: > When the driver unbinds, pmu is unregistered and i915->uabi_engines is > set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine > events, it issues a warn_on because engine lookup fails. > > All perf h

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-24 Thread Andi Shyti
Hi Umesh, On Thu, Oct 19, 2023 at 11:28:36AM -0700, Umesh Nerlige Ramappa wrote: > When the driver unbinds, pmu is unregistered and i915->uabi_engines is > set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine > events, it issues a warn_on because engine lookup fails. > > All perf h

[Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-20 Thread Umesh Nerlige Ramappa
When the driver unbinds, pmu is unregistered and i915->uabi_engines is set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine events, it issues a warn_on because engine lookup fails. All perf hooks are taking care of this using a pmu->closed flag that is set when PMU unregisters. The

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-20 Thread Tvrtko Ursulin
On 19/10/2023 19:28, Umesh Nerlige Ramappa wrote: When the driver unbinds, pmu is unregistered and i915->uabi_engines is set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine events, it issues a warn_on because engine lookup fails. All perf hooks are taking care of this using a p

[Intel-gfx] [PATCH] drm/i915/pmu: Check if pmu is closed before stopping event

2023-10-19 Thread Umesh Nerlige Ramappa
When the driver unbinds, pmu is unregistered and i915->uabi_engines is set to RB_ROOT. Due to this, when i915 PMU tries to stop the engine events, it issues a warn_on because engine lookup fails. All perf hooks are taking care of this using a pmu->closed flag that is set when PMU unregisters. The